Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cursor placement clicking inside Entry widget #2947

Merged
merged 1 commit into from May 2, 2022

Conversation

chrisbirster
Copy link
Contributor

Description:

Reproducible in the fyne_demo app where clicking the empty space inside the multi-line entry widget causes the cursor to jump to the beginning of row instead of the end.

Before:
https://user-images.githubusercontent.com/15853349/165876725-6d6e9eda-6f07-4208-9d48-300dcefda69d.mov

After:
https://user-images.githubusercontent.com/15853349/165876757-0e5fed20-e22b-4acd-8ba1-a40602eb2c69.mov

Fixes #2877

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 61.638% when pulling f763182 on chrisbirster:entry-empy-space into c36764a on fyne-io:develop.

Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@andydotxyz andydotxyz merged commit b82b5ee into fyne-io:develop May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants