Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: Various changes to CI linting #2855

Closed
wants to merge 10 commits into from
Closed

RFC: Various changes to CI linting #2855

wants to merge 10 commits into from

Commits on Mar 19, 2022

  1. Replace goimports with gofumpt and drop golint 

    Gofumpt has been working out very well for me and I am impressed with what it does.
It is actively maintained and works well as a replacement to goimports.
I also removed golint as it is deprecated. Staticcheck handles our needs now.
    @Jacalz
    Jacalz committed Mar 19, 2022
    Configuration menu
    Copy the full SHA
    8517693 View commit details
    Browse the repository at this point in the history

  2. Add in changes for gofumpt formatting

    @Jacalz
    Jacalz committed Mar 19, 2022
    Configuration menu
    Copy the full SHA
    6b6d433 View commit details
    Browse the repository at this point in the history

  3. Fix a small typo (that broke everything)

    @Jacalz
    Jacalz committed Mar 19, 2022
    Configuration menu
    Copy the full SHA
    6c62978 View commit details
    Browse the repository at this point in the history

  4. Let's see if we can ingore install recommends for CI

    @Jacalz
    Jacalz committed Mar 19, 2022
    Configuration menu
    Copy the full SHA
    a01ace9 View commit details
    Browse the repository at this point in the history

  5. See how clang affects download sizes 

    No install recommends had no effect.
    @Jacalz
    Jacalz committed Mar 19, 2022
    Configuration menu
    Copy the full SHA
    5c0b4bf View commit details
    Browse the repository at this point in the history

  6. Try to make gofumpt work in CI

    @Jacalz
    Jacalz committed Mar 19, 2022
    Configuration menu
    Copy the full SHA
    82d82d7 View commit details
    Browse the repository at this point in the history

  7. Try again to get gofumpt working

    @Jacalz
    Jacalz committed Mar 19, 2022
    Configuration menu
    Copy the full SHA
    47ad31f View commit details
    Browse the repository at this point in the history

  8. Let's tackle using clang at another time

    @Jacalz
    Jacalz committed Mar 19, 2022
    Configuration menu
    Copy the full SHA
    ad56aa3 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2022

  1. Update gocyclo to hopefully fix static analysis

    @Jacalz
    Jacalz committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    fd6774e View commit details
    Browse the repository at this point in the history

  2. Work around the bug in gofumpt

    @Jacalz
    Jacalz committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    0541550 View commit details
    Browse the repository at this point in the history