New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/fyne: support -os iossimulator #2495
Conversation
Do we need another target system to support this? the iOS package already includes both amd64 and arm64... |
Yes, but only works for darwin/amd64 systems. The iOS simulator fails on M1 macs. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
9e26d6a
to
8379d88
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There must be a way to support this new feature without removing 32bit iOS support?
719e20f
to
37aba3b
Compare
My darwin/amd64 was broken recently and have been sent to a repair center which might take weeks to repair. After rebase based on the latest develop branch, I could not even run Looks like I have completely lost track here. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
37aba3b
to
36e892b
Compare
36e892b
to
7e613e8
Compare
7e613e8
to
daff9de
Compare
I think I've figured the problem. As I tested the latest status of this PR on two of my Macs, it has fixed the previous concerned issue. Now the code works both for PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and working well thanks.
It is a shame about the duplicate file, but I guess with the import issues it is not possible to resolve another way?
We can remove the old file once we stop supporting Go 1.14 ;)
Description:
This PR adds
-os iossimulator
to the fyne command, and fixes the iOS simulator issue on darwin/arm64.Fixes #1917
Checklist: