Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google play console minimum API level 31 #3375

Closed
2 tasks done
vejjux opened this issue Nov 4, 2022 · 7 comments
Closed
2 tasks done

Google play console minimum API level 31 #3375

vejjux opened this issue Nov 4, 2022 · 7 comments
Labels
blocker Items that would block a forthcoming release unverified A bug that has been reported but not verified

Comments

@vejjux
Copy link

vejjux commented Nov 4, 2022

Checklist

  • I have searched the issue tracker for open issues that relate to the same problem, before opening a new one.
  • This issue only relates to a single bug. I will open new issues for any other problems.

Describe the bug

Google play console complains about minimum required API level being 31, while built .aab targets 30.

Actual error message:

Your app currently targets API level 30 and must target at least API level 31 to ensure it is built on the latest APIs optimized for security and performance. Change your app's target API level to at least 31

How to reproduce

  1. Build an app packaged as android .aab bundle using fyne release -os android
  2. Go to google play console
  3. Create a release
  4. Upload created .aab

Screenshots

min-android-version

Example code

cmd/fyne/internal/mobile/build.go:146

target := 30
if !buildRelease {
	target = 29 // TODO once we have gomobile debug signing working for v2 android signs
}

Fyne version

2.2.3

Go compiler version

1.19.2

Operating system

Android

Operating system version

not aplicable

Additional Information

No response

@vejjux vejjux added the unverified A bug that has been reported but not verified label Nov 4, 2022
@andydotxyz andydotxyz added the blocker Items that would block a forthcoming release label Nov 6, 2022
andydotxyz added a commit to andydotxyz/fyne that referenced this issue Nov 6, 2022
@andydotxyz
Copy link
Member

Thanks, I had missed the moved the version up again. PR is open - needs a bunch of testing...

@vejjux
Copy link
Author

vejjux commented Nov 7, 2022

Seams to be working, thanks.
Still had to use custom manifest with added:
android:debuggable="false" and android:exported="true" for play console to accept it.

@andydotxyz
Copy link
Member

the debuggable should have been set already, that is strange.

Can you provide the exact diff that you applied so I can go check @vejjux ? The exported field is something I didn't understand when reading the release notes but clearly needs action.

@vejjux
Copy link
Author

vejjux commented Nov 7, 2022

Sorry, my bad, I must have copied debuggable when creating the manifest.

  • I used generic fyne.io/fyne/v2 v2.2.3 for dependencies.
  • Used github.com/andydotxyz/fyne/v2@0dbb74fc9a198af21adf31d54038fa6b7ecddbd6 for the fyne command to build release bundle
  • The error in play console mentioned, that all activities/services that use intent filters must have exported set to true.

@vejjux
Copy link
Author

vejjux commented Nov 7, 2022

	<activity android:name="org.golang.app.GoNativeActivity"
		android:label="{{.Name}}"
		android:configChanges="orientation|keyboardHidden|uiMode"
		android:theme="@android:style/Theme"
		android:exported="true">
		<meta-data android:name="android.app.lib_name" android:value="{{.LibName}}" />
		<intent-filter>
			<action android:name="android.intent.action.MAIN" />
			<category android:name="android.intent.category.LAUNCHER" />
		</intent-filter>
	</activity>

@andydotxyz
Copy link
Member

Can you please try the latest branch and see if we're good now? @vejjux :)

@andydotxyz
Copy link
Member

Fixed on develop :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker Items that would block a forthcoming release unverified A bug that has been reported but not verified
Projects
None yet
Development

No branches or pull requests

2 participants