Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Linux/XDG app settings to delegate theme to new fd.o color-scheme #2657

Closed
andydotxyz opened this issue Nov 22, 2021 · 16 comments
Closed
Labels
enhancement New feature or request

Comments

@andydotxyz
Copy link
Member

Updating the app/app_xdg.go function defaultVariant to look up the value now defined "globally" https://github.com/flatpak/xdg-desktop-portal/blob/d7a304a00697d7d608821253cd013f3b97ac0fb6/data/org.freedesktop.impl.portal.Settings.xml#L33-L45

@andydotxyz andydotxyz added the enhancement New feature or request label Nov 22, 2021
@Jacalz

This comment has been minimized.

@Jacalz
Copy link
Member

Jacalz commented Dec 21, 2021

I have dug a bit deeper and this appears to be a proper freedesktop specification now that should be supported in Gnome 42 and ElementaryOS 6.1 (probably KDE Plasma in the future as well). This link has pretty much all the details: https://blogs.gnome.org/alexm/2021/10/04/dark-style-preference/

@andydotxyz
Copy link
Member Author

That blog post is helpful, but I still cannot find any documentation that is not in a gnome blog post or wiki ;)

@Jacalz
Copy link
Member

Jacalz commented Dec 22, 2021

True. That part is a bit weird but I think the above link should have most of what is needed to implement it. I did found out about this from the elementary OS 6.1 release notes though: https://blog.elementary.io/elementary-os-6-1-available-now/.

@andydotxyz
Copy link
Member Author

Don't they get it for free from using the latest Gnome libs? i.e. it may still be proposed at the Gnome side rather than ratified standard...

@Jacalz
Copy link
Member

Jacalz commented Dec 22, 2021

Maybe. Seems like they really want it to be a standard though. Maybe the standard just hasn't been published yet? Seems like they have good intentions for making it a standard either way. We are probably closer now than we ever have been with this.

@andydotxyz
Copy link
Member Author

There is now a decent impl to reference pbek/QOwnNotes@3933a89

@metal3d
Copy link
Contributor

metal3d commented Nov 18, 2022

I made an implementation here: fyne-io/fyne-x#48

@Jacalz
Copy link
Member

Jacalz commented Nov 18, 2022

@metal3d Would you care to bring the functionality specific to this issue into the main code base here? We already follow light/dark themes on Windows/macOS and it would be great if we do so on Linux as well :)

@metal3d
Copy link
Contributor

metal3d commented Nov 18, 2022

Yes, I can propose the theme here.

Of course, as you see, I found ways to follow dark/light theme on Linux, but I think there is a few of decision to take on what I did.
But we can discuss on the PR.

Let me a few minute to make the PR 😄

@metal3d
Copy link
Contributor

metal3d commented Nov 18, 2022

This is done here: #3410

@Jacalz
Copy link
Member

Jacalz commented Nov 19, 2022

I think there was a misunderstanding here. I meant the part about only switching the default FyneTheme between dark and light (exactly what this issue relates to), not bringing in everything about icons and such (at least not yet).

@andydotxyz
Copy link
Member Author

I think #3414 should be what you were considering @Jacalz ?

@Jacalz
Copy link
Member

Jacalz commented Nov 19, 2022

Ah, I see. I missed that one, it seems. Thanks :)

@andydotxyz
Copy link
Member Author

Not at all, it is new this morning after some chat in contributor channel last night

@andydotxyz
Copy link
Member Author

Nicely completed, thanks @metal3d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants