Abort on warnings again

lib/zeitwerk/loader/config.rb

@@ -298,9 +298,9 @@ def log!
     # Common use case.
     return false if ignored_paths.empty?
 
-    walk_up(abspath) do |abspath|
-      return true  if ignored_path?(abspath)
-      return false if roots.key?(abspath)
+    walk_up(abspath) do |path|
+      return true  if ignored_path?(path)
+      return false if roots.key?(path)
     end
 
     false

test/support/no_warnings_policy.rb

@@ -1,17 +1,23 @@
 # frozen_string_literal: true
 
 module NoWarningsPolicy
-  MESSAGE = "This test suite aborts on warnings, please fix the one above."
+  def ignore?(msg)
+    msg.include?("Zeitwerk defines the constant")
+  end
+
+  def halt
+    abort("This test suite aborts on warnings, please fix the one above.")
+  end
 
   if Warning.method(:warn).arity == 1
-    def warn(*)
+    def warn(msg)
       super
-      abort(MESSAGE)
+      halt unless ignore?(msg)
     end
   else
-    def warn(*, **)
+    def warn(msg, **)
       super
-      abort(MESSAGE)
+      halt unless ignore?(msg)
     end
   end
 end

test/test_helper.rb

@@ -7,7 +7,7 @@
 require "minitest/reporters"
 Minitest::Reporters.use!(Minitest::Reporters::DefaultReporter.new)
 
-# require_relative "support/no_warnings_policy"
+require_relative "support/no_warnings_policy"
 require_relative "support/test_macro"
 require_relative "support/delete_loaded_feature"
 require_relative "support/loader_test"