Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved the bottom reaching detection. #1308

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improved the bottom reaching detection. #1308

wants to merge 1 commit into from

Commits on Dec 13, 2022

  1. Improved the bottom reaching detection. 

    These values are floating point in some environments.
The scroll position plus the height of the visible area may not exactly match the height of the element.

By changing to the calculation formula introduced on MDN, it will correctly determine that you have reached the bottom of the container element.
https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollHeight#determine_if_an_element_has_been_totally_scrolled
    @hitode909
    hitode909 committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    efc4ece View commit details
    Browse the repository at this point in the history