Fix Continuous Manager Scrolling Bugs #1305
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the issue of the scroll bar not working if the rendition is resized while an image is present and using continuous manager
btpf
changed the title
NoraH1to
reviewed
May 21, 2023
There was a problem hiding this comment.
Function.prototype.bind() will return a new function, but will not call it.
This will therefore invalidate the fill method, causes some problems when turning pages.
The reason for queue blocking is that the promise indicating the iframe loading state may always be pending, see #1336
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug related to issues #1295, #1303