Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
book.locations.generate
andrendition.display
with a proper fraction (between 0 and 1) value, it has a possibility that the ePub CFI range contains only an empty string. It causes this line returns a all-zeros position:epub.js/src/contents.js
Line 658 in a1e77b7
This browser inspector screenshot shows the problem:
To fix this problem, we can use the parent element containing the range to get a valid bounding rect.
position = range.startContainer.parentElement.getBoundingClientRect();