Fix navigation with proper fraction #1128
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction with different writing modes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two lines could have numbers between 0 and 1 (proper fractions) during navigations:
epub.js/src/managers/default/index.js
Line 451 in a1e77b7
epub.js/src/managers/default/index.js
Line 562 in a1e77b7
Even if an ePub section (e.g. a cover page or a table of content page) has only one page, a proper fraction causes prev() or next() can't correct go to the previous or next section, because these condition tests are true:
epub.js/src/managers/default/index.js
Line 451 in a1e77b7
epub.js/src/managers/default/index.js
Line 562 in a1e77b7
A browser inspector confirms the problem (this.container.scrollLeft has a value 0.8000...):
In user perspective, user has to execute prev() or next() twice to correctly go to the previous or next section!
This pull request fixes only two navigation cases (depending on section layouts), not all navigation cases, because my tested ePub files can only triggers these two cases.