Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix lint error #1438

Merged
merged 4 commits into from Apr 15, 2022
Merged

chore: fix lint error #1438

merged 4 commits into from Apr 15, 2022

Conversation

MaineK00n
Copy link
Collaborator

@MaineK00n MaineK00n commented Apr 5, 2022

What did you implement:

Fixed a lint error caused by revive and golangci-lint.
Reviewed the tasks in GNUmakefile and changed (pre)test to be done in all instead of build.

Also, Trivy binary is now included with fvuls image.

$ docker run -it --rm vuls/fvuls /bin/sh
/vuls # ls /usr/local/bin
future-vuls    trivy          trivy-to-vuls  vuls

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

$ make test
$ make golangci

Checklist:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES

Reference

@MaineK00n MaineK00n self-assigned this Apr 5, 2022
@MaineK00n MaineK00n force-pushed the MaineK00n/fix-lint-error branch 2 times, most recently from 01552c4 to 4b6b854 Compare April 5, 2022 21:38
@MaineK00n MaineK00n merged commit 8775b5e into master Apr 15, 2022
@MaineK00n MaineK00n deleted the MaineK00n/fix-lint-error branch April 15, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant