Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added lfs True to maven.yml #223

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

ajohnsson95
Copy link

Added lfs true for large files to be properly checked out

Copy link

@Charlottehenriksson Charlottehenriksson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to be adding lfs correctly, nice!

Copy link
Contributor

@kappsegla kappsegla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this update be in the release.yml file? maven.yml is for CI and doesn't build the docker images.

alexander-tf2fan

This comment was marked as outdated.

@alexander-tf2fan alexander-tf2fan dismissed their stale review February 18, 2024 21:06

Made a mistake by not looking through kappsegla's review. I didn't notice the mistake and I was wrong with my reivew.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants