feat(lambda,event-bridge): lambda event sources #179

thantos · 2022-05-31T19:27:47Z

Closes #44

Depends on #161 - This change made major changes to EventBus, stacking these changes to reduce churn.

Lambda
Step Functions - Already done
❌ Api Gateway
❌ App Sync
❌ Dynamo

Lambda

Unlike Step Functions, Lambda does not emit events by default. Lambda has a concept of a destination or async invocation. Each lambda, version, and alias can only have a single onSuccess and onFailure destination. Destinations can be EventBuses, Sns topics, Sqs queues, or other lambda functions.

const func = new Function(stack, 'func', {
   onSuccess: bus, // IEventBus | IFunction | aws_lambda.IDestination
   onFailure: bus // IEventBus | IFunction | aws_lambda.IDestination
});

// fail when onSuccess is not set and not a bus?
func.onSuccess(bus).map().pipe();
func.onFailure(bus).map().pipe();

src/function.ts

…tionless into event_source_2

src/event-bridge/event-bus.ts

sam-goodwin · 2022-06-08T00:16:59Z

src/event-bridge/event-bus.ts

@@ -115,16 +120,16 @@ export interface IEventBusFilterable<E extends Event> {
  ): Rule<E, O>;
 }

-export interface IEventBus<E extends Event = Event>
+export interface IEventBus<in E extends Event = Event, O extends E = E>


Might want to document the type parameters. Not immediately obvious what E and O mean

In standard libraries, I usually prefer to use words for type parameters instead of symbols.

Thanks, that was a helpful exercise.

/** * @typeParam Evnt - the union type of events that this EventBus can accept. * `Evnt` is the covariant version of `OutEnvt` in that * the bus will accept any of `Evnt` while the EventBus can * emit any of `OutEvnt`. * @typeParam OutEvnt - the union type of events that this EventBus will emit through rules. * `OutEvnt` is the contravariant version of `Envt` in that * the bus will emit any of `OutEvnt` while the EventBus can * can accept any of `Evnt`. This type parameter should be left * empty to be inferred. */

src/event-bridge/event-bus.ts

sam-goodwin · 2022-06-08T00:18:32Z

src/function.ts

+   *
+   * ```ts
+   * const bus = new EventBus(stack, 'bus');
+   * new Function(stack, 'func', { onSuccess: bus }, async () => {});


src/function.ts

sam-goodwin · 2022-06-08T09:30:00Z

Should the title of the PR be more granular? Would someone reading the CHANGELOG know what this change is about based purely on the title?

thantos · 2022-06-08T11:28:05Z

Should the title of the PR be more granular? Would someone reading the CHANGELOG know what this change is about based purely on the title?

Ha... the change started with higher ambitions and then I realized that no one else but lambda and step function publish events!

Will update.

Signed-off-by: github-actions <github-actions@github.com>

…tionless into event_source_2

sam-goodwin · 2022-06-09T05:29:36Z

src/event-bridge/rule.ts

+ * @typeParam - Evnt - The original event type from the {@link EventBus}.
+ * @typeParam - OutEvnt - The narrowed event type after the predicate is applied.
+ */
+export interface IRule<in Evnt extends Event, out OutEvnt extends Evnt> {


Why do we need two type parameters?

Evnt is the event in. The input to the predicate on the rule.

OutEvnt is the narrowed type as the input to pipe or map or when.

Essentially splitting and showing the two sides of the predicate.

Why do you need Evnt?

Its being used on integration: IntegrationWithEventBus<Evnt, Props>,

But that doesn't seem right... will look.

sam-goodwin · 2022-06-09T05:31:29Z

src/event-bridge/event-bus.ts

-  when<O extends E>(
+    predicate: RulePredicateFunction<InEvnt, NewEvnt>
+  ): Rule<InEvnt, NewEvnt>;
+  when<InEvnt extends OutEvnt, NewEvnt extends InEvnt>(


These two parameters seem overly complex and redundant. Why did you add them?

Need to invert the inEvnttoout NewEvntandout OutEvnttoin InEvnt` for the when method.

sam-goodwin · 2022-06-09T05:31:56Z

src/event-bridge/event-bus.ts

-  extends IEventBusFilterable<E>,
+/**
+ * @typeParam Evnt - the union type of events that this EventBus can accept.
+ *                   `Evnt` is the covariant version of `OutEvnt` in that


Evnt is contra-variant, not co-variant. out is for covariance

sam-goodwin · 2022-06-09T05:33:01Z

src/event-bridge/event-bus.ts

+ *                      can accept any of `Evnt`. This type parameter should be left
+ *                      empty to be inferred. ex: `EventBus<Event<Detail1> | Event<Detail2>>`.
+ */
+export interface IEventBus<in Evnt extends Event = Event, OutEvnt extends Evnt = Evnt>


This doesn't seem right. I think we can remove the OutEvnt

sam-goodwin

We can modify the types in a subsequent change. Ship it

thantos · 2022-06-11T13:19:44Z

We can modify the types in a subsequent change. Ship it

Removed the unessecary in Evnt from IRule and RuleBase which cleaned up a bit.

Also fixed the covariance/contravariant naming issues and think I understand them better now :-)

https://dmitripavlutin.com/typescript-covariance-contravariance/

thantos · 2022-06-11T17:34:15Z

Error: Cannot find module '/opt/build/repo/scripts/compile-error-code-page'

I don't understand what changed

thantos added 17 commits May 26, 2022 17:48

chore: update rule name

e99cca9

feat(EventBus): schedule, whenAny, rename, when without scope

22e4057

chore: update repo reference

242f086

Merge branch 'main' into event_bus_v2_2

49a0eb1

fix: change whenAny to all

240d94e

feat: event bridge docs

0b9bd85

Merge branch 'main' into event_bus_v2_2

811d000

Merge branch 'main' into event_bus_v2_2

81a6edc

fix: feedback

062ba3e

feat: breaking change: update bus invocation to putEvents method

50f0c3d

feat: rename EventBusEvent interface to Event

0e187f5

feat: more docs

2e73a83

feat: pipe escape hatch and escape hatch docs

bd92146

feat(lambda,step-functions,event-bridge): event sources

f3c4c12

fix: sussman is bad at spelling

b40fe5e

feat: lambda event sources

b644d08

Merge branch 'event_bus_v2_2' into event_source_2

bb88954

thantos changed the base branch from main to event_bus_v2_2 May 31, 2022 21:33

thantos added 3 commits May 31, 2022 22:29

fix: add missing ids to when statements

be9f3fa

Merge branch 'event_bus_v2_2' into event_source_2

b5b449f

fix: failing test-app

d8223ae

sam-goodwin requested changes Jun 1, 2022

View reviewed changes

src/function.ts Show resolved Hide resolved

src/function.ts Outdated Show resolved Hide resolved

thantos added 4 commits June 1, 2022 07:25

feat: tests

63550ff

feat: configure async

84f8889

feat: comments

96d3998

chore: docs

fcb8edb

thantos added event-bridge lambda labels Jun 1, 2022

thantos changed the title ~~feat(lambda,step-functions,event-bridge): event sources~~ feat(lambda,event-bridge): event sources Jun 1, 2022

thantos marked this pull request as ready for review June 1, 2022 13:46

thantos added 2 commits June 7, 2022 09:27

Merge branch 'event_source_2' of https://github.com/functionless/func…

bd37996

…tionless into event_source_2

Merge branch 'main' into event_source_2

f0ac49c

thantos requested a review from sam-goodwin June 7, 2022 22:26

sam-goodwin approved these changes Jun 8, 2022

View reviewed changes

Merge branch 'main' into event_source_2

53016f8

thantos changed the title ~~feat(lambda,event-bridge): event sources~~ feat(lambda,event-bridge): lambda event sources Jun 8, 2022

thantos and others added 10 commits June 8, 2022 08:47

fix: renaming type params and fixing variance

5a7c076

fix: event bus variant coverage

4e1fc75

chore: document event bus types

68be9d4

chore: function type docs, naming, and variance

f85a60e

Merge branch 'main' into event_source_2

4d59856

chore: skip lib check test app

32c7def

fix: rename configureAsyncInvoke to enableAsyncInvoke

5eb61a8

chore: self mutation

406ae98

Signed-off-by: github-actions <github-actions@github.com>

formatting

761cf5a

Merge branch 'event_source_2' of https://github.com/functionless/func…

a19df01

…tionless into event_source_2

sam-goodwin reviewed Jun 9, 2022

View reviewed changes

sam-goodwin approved these changes Jun 11, 2022

View reviewed changes

thantos added 2 commits June 11, 2022 07:37

Merge branch 'main' into event_source_2

4bb3260

fix: remove extra type parameters in rules, fix variant labeling

7bf95e0

fix: reduce use of covariant types

471e64f

thantos merged commit 509e6f7 into main Jun 11, 2022

thantos deleted the event_source_2 branch June 11, 2022 17:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(lambda,event-bridge): lambda event sources #179

feat(lambda,event-bridge): lambda event sources #179

thantos commented May 31, 2022 •

edited

sam-goodwin Jun 8, 2022

sam-goodwin Jun 8, 2022

thantos Jun 8, 2022

sam-goodwin Jun 8, 2022

sam-goodwin commented Jun 8, 2022

thantos commented Jun 8, 2022

sam-goodwin Jun 9, 2022

thantos Jun 9, 2022

sam-goodwin Jun 9, 2022

thantos Jun 9, 2022

sam-goodwin Jun 9, 2022

thantos Jun 9, 2022

sam-goodwin Jun 9, 2022

sam-goodwin Jun 9, 2022

sam-goodwin left a comment

thantos commented Jun 11, 2022

thantos commented Jun 11, 2022

feat(lambda,event-bridge): lambda event sources #179

feat(lambda,event-bridge): lambda event sources #179

Conversation

thantos commented May 31, 2022 • edited

Lambda

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sam-goodwin commented Jun 8, 2022

thantos commented Jun 8, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sam-goodwin left a comment

Choose a reason for hiding this comment

thantos commented Jun 11, 2022

thantos commented Jun 11, 2022

thantos commented May 31, 2022 •

edited