Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update golang.org/x/sys to support Go 1.18 #178

Merged
merged 1 commit into from Jun 15, 2022

Conversation

maximus1108
Copy link
Contributor

@maximus1108 maximus1108 commented Apr 7, 2022

Changes to go.mod and go.sum that result from running:

go get -u golang.org/x/sys

This update is to support running go install github.com/fullstorydev/grpcui/cmd/grpcui@latest when using Go 1.18.

@maximus1108 maximus1108 changed the title fix: update go get -u golang.org/x/sys to support Go 1.18 fix: update golang.org/x/sys to support Go 1.18 Apr 7, 2022
@minhtus
Copy link

minhtus commented Apr 10, 2022

+ 1
golang/go#49219

@GaoJianAllen
Copy link

@jhump Could you review the PR? I can't install grpcui in go 1.18. Thanks.

@josephw-ml
Copy link

How can this PR and merge become a higher priority for review?
OR
Is there a way of resolving this bug while this PR waits?
@maximus1108

@dragonsinth
Copy link
Member

#187

@dragonsinth dragonsinth merged commit 347dfad into fullstorydev:master Jun 15, 2022
@HurSungYun
Copy link

HurSungYun commented Aug 4, 2022

@dragonsinth Could you please release new version including this PR?

go install github.com/fullstorydev/grpcui/cmd/grpcui@latest seems not working now in Go 1.18.

@dragonsinth
Copy link
Member

@dragonsinth Could you please release new version including this PR?

Hi @HurSungYun we do plan to release a new version. I'm on vacation this week tho.

go install github.com/fullstorydev/grpcui/cmd/grpcui@latest seems not working now in Go 1.18.

Is this what you're seeing?

# golang.org/x/sys/unix
go/pkg/mod/golang.org/x/sys@v0.0.0-20200331124033-c3d80250170d/unix/syscall_darwin.1_13.go:25:3: //go:linkname must refer to declared function or variable
go/pkg/mod/golang.org/x/sys@v0.0.0-20200331124033-c3d80250170d/unix/zsyscall_darwin_arm64.1_13.go:27:3: //go:linkname must refer to declared function or variable
go/pkg/mod/golang.org/x/sys@v0.0.0-20200331124033-c3d80250170d/unix/zsyscall_darwin_arm64.1_13.go:40:3: //go:linkname must refer to declared function or variable
go/pkg/mod/golang.org/x/sys@v0.0.0-20200331124033-c3d80250170d/unix/zsyscall_darwin_arm64.go:28:3: //go:linkname must refer to declared function or variable
go/pkg/mod/golang.org/x/sys@v0.0.0-20200331124033-c3d80250170d/unix/zsyscall_darwin_arm64.go:43:3: //go:linkname must refer to declared function or variable
go/pkg/mod/golang.org/x/sys@v0.0.0-20200331124033-c3d80250170d/unix/zsyscall_darwin_arm64.go:59:3: //go:linkname must refer to declared function or variable
go/pkg/mod/golang.org/x/sys@v0.0.0-20200331124033-c3d80250170d/unix/zsyscall_darwin_arm64.go:75:3: //go:linkname must refer to declared function or variable
go/pkg/mod/golang.org/x/sys@v0.0.0-20200331124033-c3d80250170d/unix/zsyscall_darwin_arm64.go:90:3: //go:linkname must refer to declared function or variable
go/pkg/mod/golang.org/x/sys@v0.0.0-20200331124033-c3d80250170d/unix/zsyscall_darwin_arm64.go:105:3: //go:linkname must refer to declared function or variable
go/pkg/mod/golang.org/x/sys@v0.0.0-20200331124033-c3d80250170d/unix/zsyscall_darwin_arm64.go:121:3: //go:linkname must refer to declared function or variable
go/pkg/mod/golang.org/x/sys@v0.0.0-20200331124033-c3d80250170d/unix/zsyscall_darwin_arm64.go:121:3: too many errors

@HurSungYun
Copy link

Thank you for replying! I hope you enjoying your vacation.

It's great to hear that there's a plan to release a new version. Every person who wanna install grpcui with Go 1.18 would have same problem with me. So, I wish I can have new version including latest commit.

Btw, I solved this problem by specifying latest commit. go install github.com/fullstorydev/grpcui/cmd/grpcui@410c0c38e668e8a94f7dfb2abfd77a8d1c3dd4be worked well.

@dragonsinth
Copy link
Member

Ahhh, that makes sense. latest would refer to the latest tagged version, which is broken. You could also go install github.com/fullstorydev/grpcui/cmd/grpcui@master to get the HEAD revision. So basically we need to do a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants