Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with eventContent w/ Angular (list view & resource timeline) #7058

Closed
Telio3 opened this issue Dec 14, 2022 · 9 comments
Closed

Error with eventContent w/ Angular (list view & resource timeline) #7058

Telio3 opened this issue Dec 14, 2022 · 9 comments
Milestone

Comments

@Telio3
Copy link

Telio3 commented Dec 14, 2022

Bug Description

With version 6, I used the eventContent template. (on Angular 14 and 15)
The render goes well on the view dayGridMonth, timeGridWeek, timeGridDay but not on the list and resource timeline.

This error completely crashes the full calendar actions.

image

@acerix
Copy link
Member

acerix commented Dec 15, 2022

Would you be able to post a runnable, stripped-down demonstration of the bug? Would really appreciate it because the time saved reproducing will be time spent fixing.

@acerix acerix closed this as completed Dec 15, 2022
@Telio3
Copy link
Author

Telio3 commented Dec 15, 2022 via email

@arshaw arshaw changed the title Error with eventContent template in list view Error with eventContent w/ Angular (possibly only list view) Dec 15, 2022
@arshaw arshaw reopened this Dec 15, 2022
@arshaw arshaw added this to the v6-upcoming milestone Dec 15, 2022
@Telio3 Telio3 changed the title Error with eventContent w/ Angular (possibly only list view) Error with eventContent w/ Angular (list view & resource timeline) Dec 16, 2022
@arshaw
Copy link
Member

arshaw commented Dec 20, 2022

I can reproduce this with list view but no resource timeline. updated repro:
https://stackblitz.com/edit/angular-ivy-5ks6m5?file=package.json,src%2Fapp%2Fapp.component.ts

@arshaw
Copy link
Member

arshaw commented Dec 20, 2022

Working okay in v5. This seems like a regression.
https://stackblitz.com/edit/github-jfnn7z?file=src%2Fapp%2Fapp.component.ts

@Telio3
Copy link
Author

Telio3 commented Dec 20, 2022

Working okay in v5. This seems like a regression. https://stackblitz.com/edit/github-jfnn7z?file=src%2Fapp%2Fapp.component.ts

Yes, it worked in previous versions.
But eventContent template is very interesting for my use.

@arshaw
Copy link
Member

arshaw commented Dec 20, 2022

Fixed in v6.0.1

Updated working repro:
https://stackblitz.com/edit/angular-ivy-2jddo7?file=package.json,src%2Fapp%2Fapp.component.ts

@arshaw arshaw closed this as completed Dec 20, 2022
@hoangdinhcong
Copy link

Hi @arshaw ,

Thank you for this upgrade 🔥.
I updated my repo to v6.0.1. Seem like everything works. But the errors I mentioned before still happened 😢
Please take a look. Thank you so much.

My issue: fullcalendar/fullcalendar-angular#426 (comment)
Here is my updated repo: https://stackblitz.com/edit/github-msefaz?file=src%2Fapp%2Fmy-calendar%2Fmy-calendar.component.html

An error occurs when I close the dialog which has fullcalendar inside:

preview-d0bbfde89eb2a.js:2 ERROR DOMException: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node.
    at TransportContainerComponent.ngOnDestroy (https://github-msefaz.stackblitz.io/turbo_modules/@fullcalendar/angular@6.0.1/fesm2015/fullcalendar-angular.mjs:164:24)
    at executeOnDestroys (https://github-msefaz.stackblitz.io/turbo_modules/@angular/core@15.0.4/fesm2015/core.mjs:6454:32)
    at cleanUpView (https://github-msefaz.stackblitz.io/turbo_modules/@angular/core@15.0.4/fesm2015/core.mjs:6364:9)
    at destroyViewTree (https://github-msefaz.stackblitz.io/turbo_modules/@angular/core@15.0.4/fesm2015/core.mjs:6197:17)
    at destroyLView (https://github-msefaz.stackblitz.io/turbo_modules/@angular/core@15.0.4/fesm2015/core.mjs:6342:9)
    at ViewContainerRef.remove (https://github-msefaz.stackblitz.io/turbo_modules/@angular/core@15.0.4/fesm2015/core.mjs:22721:13)
    at ViewContainerRef.clear (https://github-msefaz.stackblitz.io/turbo_modules/@angular/core@15.0.4/fesm2015/core.mjs:22564:18)
    at NgIf._updateView (https://github-msefaz.stackblitz.io/turbo_modules/@angular/common@15.0.4/fesm2015/common.mjs:3540:37)
    at set ngIf [as ngIf] (https://github-msefaz.stackblitz.io/turbo_modules/@angular/common@15.0.4/fesm2015/common.mjs:3507:14)

@hoangdinhcong
Copy link

Hi @arshaw ,

I realized that the collapse button in the resources left panel also doesn't work and occurs the same error.
I've updated my repo. Please take a look. Thank you so much:
https://stackblitz.com/edit/github-msefaz?file=src%2Fapp%2Fmy-calendar%2Fmy-calendar.component.html

image

@arshaw
Copy link
Member

arshaw commented Dec 22, 2022

@hoangdinhcong , i've made a separate ticket for your issue:
#7105

Could you please visit the link, give a 👍 to vote (?), press the 🔈Subscribe button to receive updates?

@fullcalendar fullcalendar locked as resolved and limited conversation to collaborators Dec 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants