Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certain ng-template names don't work #426

Closed
arshaw opened this issue Dec 8, 2022 · 4 comments
Closed

Certain ng-template names don't work #426

arshaw opened this issue Dec 8, 2022 · 4 comments

Comments

@arshaw
Copy link
Member

arshaw commented Dec 8, 2022

resourceLabelContent and a few others.

Originally reported in by @oliverguenther in #204 (comment):

I can't seem to get the resourceLabelContent ng-template to work. I couldn't get figure out the routing from the ContentChild to the custom rendering pipeline though to properly debug it. Do you have any pointers on where to look?

I have a minimal repo example here:
https://stackblitz.com/edit/angular-ivy-wbmq1i?file=src%2Fapp%2Fapp.component.ts,src%2Fapp%2Fapp.component.html

@arshaw
Copy link
Member Author

arshaw commented Dec 8, 2022

The bug has been fixed in my local dev environment and will be in the next release.

In the meantime, as a workaround for resourceLabelContent you can use cellContent instead (the wrong name that will for only beta.4)

@oliverguenther
Copy link

Hi @arshaw, thanks for getting back so quickly. On my app and the minimal repro example, cellContent doesn't appear to work either? The ContentChild seems to be present with that name: https://github.com/fullcalendar/fullcalendar-angular/blob/v6.0.0-beta.4/lib/src/full-calendar.component.ts#L53

@hoangdinhcong
Copy link

Hi @arshaw, thank you for your hard work. I'm very excited to upgrade to version 6.0.0 with this new feature.

But I have some errors when trying to implement the resourceLabelContent and resourceAreaHeaderContent when using it in inside a dynamic dialog in primeng. When I close the dialog it shows these errors:

ERROR DOMException: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node.
    at TransportContainerComponent.ngOnDestroy (https://github-msefaz.stackblitz.io/turbo_modules/@fullcalendar/angular@6.0.0/fesm2015/fullcalendar-angular.mjs:164:24)
    at executeOnDestroys (https://github-msefaz.stackblitz.io/turbo_modules/@angular/core@15.0.3/fesm2015/core.mjs:6454:32)
    at cleanUpView (https://github-msefaz.stackblitz.io/turbo_modules/@angular/core@15.0.3/fesm2015/core.mjs:6364:9)
    at destroyViewTree (https://github-msefaz.stackblitz.io/turbo_modules/@angular/core@15.0.3/fesm2015/core.mjs:6197:17)
    at destroyLView (https://github-msefaz.stackblitz.io/turbo_modules/@angular/core@15.0.3/fesm2015/core.mjs:6342:9)
    at ViewContainerRef.remove (https://github-msefaz.stackblitz.io/turbo_modules/@angular/core@15.0.3/fesm2015/core.mjs:22721:13)
    at ViewContainerRef.clear (https://github-msefaz.stackblitz.io/turbo_modules/@angular/core@15.0.3/fesm2015/core.mjs:22564:18)
    at NgIf._updateView (https://github-msefaz.stackblitz.io/turbo_modules/@angular/common@15.0.3/fesm2015/common.mjs:3528:37)
    at set ngIf [as ngIf] (https://github-msefaz.stackblitz.io/turbo_modules/@angular/common@15.0.3/fesm2015/common.mjs:3495:14)
    at setInputsForProperty (https://github-msefaz.stackblitz.io/turbo_modules/@angular/core@15.0.3/fesm2015/core.mjs:12467:35)

I've created a Example here. Please take a look. Thank you so much 💪

@arshaw
Copy link
Member Author

arshaw commented Dec 15, 2022

@oliverguenther, the ng-template bug you originally posted is solved in v6.0.0

@hoangdinhcong, please see this ticket:
fullcalendar/fullcalendar#7058

Could you please visit the link, give a 👍 to vote (?), press the 🔈Subscribe button to receive updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants