New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump aiobotocore to 1.4.2 #554
Conversation
python-version: ${{ matrix.python-version }} | ||
|
||
- name: Install dependencies | ||
shell: bash -l {0} | ||
run: | | ||
conda install -c conda-forge pip botocore aiobotocore "moto>=2.0" pytest flake8 black -y | ||
pip install git+https://github.com/fsspec/filesystem_spec --no-deps | ||
mamba env update -f requirements-dev.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this change, fsspec will default to the latest released version. I would prefer to install the current main branch in CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry if I'm being dense, but does this now actually install the local version of s3fs? Also, I notice lines like this apparently changing the base python version in the environment, which doesn't seem like a great idea. That particular line installs py39, even though it's the py38 run. |
Thanks for the comments. I agree more thought is needed for the best way to do this. I added a comment on an issue to move the convo there (#528). Opened up #555 as a minimal example example of what i'm trying to achieve here. Thanks for the discussion here. I'm going to close this one as I feel it the changes to ci.yml file too much. |
We tend to consider the current version of aiobotocore at release time; however, a PR bumping the requirement will be gratefully received any time, and hopefully nothing breaks. |
bumped aiobotocore to 1.4.2 and updated the ci to point to a yml file (with aiobotocore==1.4.2).
In discovery of #553 when working on a VM I got a
botocore.exceptions.NoCredentialsError: Unable to locate credentials
when I installed s3fs using conda. The tail of the Trackback looks like:However, when installing from pip which grabbed aiobotocore 1.4.2 I was able to do
pd.read_parquet("s3://bucket/file.parquet")
. This solves my use case and I hope doesn't break anything for others.