Add encoded keyword for the HTTPFileSystem #1021
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
encoded
keyword argument toHTTPFileSystem
to allow ready-encoded urls to be passed unaltered.The rationale behind this is that aiohttp, by using yarl, canonizes the urls before using them in
.get
. This works for most servers, as they are compliant with, among others, RFC3986. However, some servers, in particular the one following the OpenAPI specification, do not comply, hence making a mess for example when sending a url containing:
in the path part.To prevent the canonization of the url, aiohttp recommends here passing
encoded=True
to theyarl.URL
object creation before passing it to aiohttp'sget
. More details and examples can be provided upon request.This PR hence adds the possibility to configure the HTTPFileSystem to bypass the canonization of the urls.