add support for /tl:[auto|on|off] msbuild flag #2768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tried it (specificying
|
xperiandri
reviewed
Dec 11, 2023
smoothdeveloper
force-pushed
the
msbuild-terminallogger-flag
branch
from
25ce9f1
to
545a1d2
Compare
|
now with |
xperiandri
force-pushed
the
msbuild-terminallogger-flag
branch
from
545a1d2
to
effc697
Compare
xperiandri
approved these changes
Dec 11, 2023
|
Do you have any ideas why build fails? |
|
@xperiandri no, I see the same on another run on master branch: https://github.com/fsprojects/FAKE/actions/runs/7174371576/job/19535683031 We should investigate but I doubt it is related to this change. |
|
Probably something bad with an agent. Maybe update the version of image |
Good point, thanks! Co-authored-by: Andrii Chebukin <XperiAndri@Outlook.com>
Co-authored-by: Andrii Chebukin <XperiAndri@Outlook.com>
xperiandri
force-pushed
the
msbuild-terminallogger-flag
branch
from
effc697
to
558d9a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
see
--tl:[auto|on|off]ondotnet builddocumentation: https://learn.microsoft.com/en-gb/dotnet/core/tools/dotnet-buildSince this only works with dotnet sdk >= 8, the default case (specifying
Auto) will not emit the tag.TODO
Feel free to open the PR and ask for help
New (API-)documentation for new features exist (Note: API-docs are enough, additional docs are in
help/markdown)unit or integration test exists (or short reasoning why it doesn't make sense)
boy scout rule: "leave the code behind in a better state than you found it" (fix warnings, obsolete members or code-style in the places you worked in)
(if new module) the module has been linked from the "side navigation" menu, edit
docs/data.json.(if new module) the module is in the correct namespace.
(if new module) the module is added to Fake.sln (
dotnet sln Fake.sln add src/app/Fake.*/Fake.*.fsproj)Fake API guideline is honored