Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added shorthash to git functions #2752

Closed
wants to merge 3 commits into from

Conversation

voronoipotato
Copy link
Contributor

Description

Grabs the shorthash

@voronoipotato
Copy link
Contributor Author

@xperiandri what do you think :) ?

@voronoipotato
Copy link
Contributor Author

@xperiandri Ah I see, I need to run fantomas on it to merge. I'll handle that after work today.

@xperiandri
Copy link
Collaborator

@voronoipotato could you format your changes? Build fails

@xperiandri
Copy link
Collaborator

@DanielRowe1 let's merge this and I will release

@voronoipotato
Copy link
Contributor Author

Thanks! We use the shorthash at my work sometimes so this is pretty nice.

@voronoipotato
Copy link
Contributor Author

I'll format it after work today. Thanks!

@Numpsy
Copy link
Contributor

Numpsy commented Jan 9, 2024

fwiw I think Fantomas might just want empty lines adding before and after the new function

@xperiandri
Copy link
Collaborator

@voronoipotato

@Numpsy
Copy link
Contributor

Numpsy commented Jan 12, 2024

I tried tweaking the formatting in a separate branch over at Numpsy@ad0da7c and the formatting step of the CI build worked - https://github.com/Numpsy/FAKE/actions/runs/7504044055 - though that intermitent macOS build failure happened in the integration tests.

Not sure if I'd be able to update this PR though, or if it'd need a new one off my fork.

@Numpsy
Copy link
Contributor

Numpsy commented Feb 7, 2024

@voronoipotato This addition has hopefully been merged in #2770 now

@xperiandri
Copy link
Collaborator

@voronoipotato you can delete the branch

@xperiandri xperiandri closed this Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants