object: fix acl and project team json marshalling #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsouza
reviewed
Feb 14, 2021
|
Done. Added custom marshaller to Object instead of changing the ACL type in Object. |
fsouza
reviewed
Feb 15, 2021
|
@tarsisazevedo does this PR fix the issue you were observing? |
|
I think so @fsouza. It will send all infos in the http response as the clients expect. |
fsouza
approved these changes
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially address #420. The current ACL list does not comply with the response marshalling because the JSON field names are different than the
storage.ACLRulefield names. Created a type aliasACLRulefromstorage.ACLRule, and added custom Marshalling. Did same forstorage.ProjectTeam.