Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate ContentType field on create/modify ops #1141

Merged
merged 3 commits into from May 2, 2023

Commits on Apr 27, 2023

  1. Propagate ContentType field on create/modify ops

    This commit tries to address 2 bugs that where found when using
    some of the create/modify operations GCS supports like:
    * using the streamable upload operations of GCS to upload of a File.
    * update the blob metadata content-type without modifying the bytes of
      the blob.
    
    For the streamable upload, by default if no content-type is provided;
    GCS sets it up to 'application/octet-stream' or uses the one provided by
    the user in the BlobInfo (This is the expected behaviour for this operation in GCS).
    
    For the update, when we merge metadata information regarding the
    content-type, it should override it the update response should propagate
    this change.
    alorlea committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    63851ca View commit details
    Browse the repository at this point in the history

Commits on May 2, 2023

  1. Test for updateObject with content type

    This adds a unit test to check that when calling
    the updateObject method and a content type is provided,
    we override the previous value stored.
    alorlea committed May 2, 2023
    Configuration menu
    Copy the full SHA
    0898af6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e823414 View commit details
    Browse the repository at this point in the history