New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support segmentation for sly2yolo #265
Conversation
Co-authored-by: Flippchen <91947480+flippchen@users.noreply.github.com>
Co-authored-by: Flippchen <91947480+flippchen@users.noreply.github.com>
Co-authored-by: Flippchen <91947480+flippchen@users.noreply.github.com>
Co-authored-by: Flippchen <91947480+flippchen@users.noreply.github.com>
Co-authored-by: Flippchen <91947480+flippchen@users.noreply.github.com>
Co-authored-by: Flippchen <91947480+flippchen@users.noreply.github.com>
Hey @ddavid, do you have time to review the PR? |
Any updates on this? |
Hi, I won't have time to review for the next week or so still. Thanks @mfloto for the contribution already! |
Hey @ddavid, |
Hi @mfloto, sorry for the late reply! Could we please keep the formatting in line with what is used in the pre-commit setup? Otherwise, it looks good to go, would be great to have tests with some dummy segmentation data that has the expected format but presuming you've done some manual testing at least. I'll try and keep an eye out for the format changes and try and get this in as soon as that's in. |
Hey @ddavid, I reverted back to the pre-commit formatting. |
@mfloto thanks for reporting the issues and going through the PR again, much appreciated! Would you be interested in giving it a go to get the tools repository onto a newer python version? eg python3.10 for supporting the default py3.10 that ships with Ubuntu 22.04. There's not that may dependencies, so possibly not that much effort. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, @mfloto, much appreciated!
Thank you @ddavid for approving. Could you also merge the PR, as I don't have the required permissions. |
Sorry @mfloto, I thought approving would allow you to merge the PR, wanted to leave you the chance to "press the green button". |
Resolves #264
Use
--segmentation
flag when processing segmentation labeling.Sample command:
fsoco label-converters sly2yolo --remove_watermark --segmentation <INPUT_FOLDER> <OUTPUT_FOLDER>