Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support segmentation for sly2yolo #265

Merged
merged 7 commits into from Sep 25, 2023
Merged

Conversation

mfloto
Copy link
Contributor

@mfloto mfloto commented Jul 3, 2023

Resolves #264

Use --segmentation flag when processing segmentation labeling.

Sample command: fsoco label-converters sly2yolo --remove_watermark --segmentation <INPUT_FOLDER> <OUTPUT_FOLDER>

mfloto and others added 6 commits July 3, 2023 23:04
Co-authored-by: Flippchen <91947480+flippchen@users.noreply.github.com>
Co-authored-by: Flippchen <91947480+flippchen@users.noreply.github.com>
Co-authored-by: Flippchen <91947480+flippchen@users.noreply.github.com>
Co-authored-by: Flippchen <91947480+flippchen@users.noreply.github.com>
Co-authored-by: Flippchen <91947480+flippchen@users.noreply.github.com>
Co-authored-by: Flippchen <91947480+flippchen@users.noreply.github.com>
@Flippchen
Copy link
Contributor

Flippchen commented Jul 10, 2023

Hey @ddavid, do you have time to review the PR?

@Mooseynair
Copy link

Any updates on this?

@ddavid
Copy link
Collaborator

ddavid commented Jul 21, 2023

Hi, I won't have time to review for the next week or so still.
You can install the fosco tools from this MRs branch in the meantime?

Thanks @mfloto for the contribution already!

@mfloto
Copy link
Contributor Author

mfloto commented Aug 25, 2023

Hey @ddavid,
I just wanted to check on the status of this PR.

@ddavid
Copy link
Collaborator

ddavid commented Sep 18, 2023

Hi @mfloto, sorry for the late reply!

Could we please keep the formatting in line with what is used in the pre-commit setup?

Otherwise, it looks good to go, would be great to have tests with some dummy segmentation data that has the expected format but presuming you've done some manual testing at least.

I'll try and keep an eye out for the format changes and try and get this in as soon as that's in.

@mfloto
Copy link
Contributor Author

mfloto commented Sep 22, 2023

Hey @ddavid,

I reverted back to the pre-commit formatting.
I also noticed that the flake8 gitlab mirror configured in the .pre-commit-config.yaml does not seem to be maintained anymore (AICoE/aicoe-ci#53). Further, the set version for black is out of date and has problems working with the current version of click (psf/black#2964).

@ddavid
Copy link
Collaborator

ddavid commented Sep 24, 2023

@mfloto thanks for reporting the issues and going through the PR again, much appreciated!
I guess this is what you get with an EOL python version...

Would you be interested in giving it a go to get the tools repository onto a newer python version? eg python3.10 for supporting the default py3.10 that ships with Ubuntu 22.04. There's not that may dependencies, so possibly not that much effort.

@ddavid ddavid self-requested a review September 24, 2023 08:49
Copy link
Collaborator

@ddavid ddavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, @mfloto, much appreciated!

@mfloto
Copy link
Contributor Author

mfloto commented Sep 25, 2023

Thank you @ddavid for approving. Could you also merge the PR, as I don't have the required permissions.

@ddavid
Copy link
Collaborator

ddavid commented Sep 25, 2023

Sorry @mfloto, I thought approving would allow you to merge the PR, wanted to leave you the chance to "press the green button".

@ddavid ddavid merged commit da96674 into fsoco:master Sep 25, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image Segmentation: Supervisely to YOLO
4 participants