Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows: increase buffer size from 4K to 64K #485

Merged
merged 1 commit into from Aug 4, 2022
Merged

windows: increase buffer size from 4K to 64K #485

merged 1 commit into from Aug 4, 2022

Commits on Aug 3, 2022

  1. windows: increase buffer size from 4K to 64K

    People are running in to trouble because the 4K buffer can overflow;
    see: #72.
    
    This is not a "real" fix, but I think a 64K buffer is acceptable even on
    memory-limited machines; no one is running the Windows on an Arduino,
    and even with something like 128M of memory, the extra 124K is basically
    negligible. There is also no real performance difference between
    allocating a large array vs. a small array: they're both comparable.
    
    It should probably be enough for most applications. Need to look in the
    future to either dynamically grow the size, or allow setting it similar
    to what tilt does as mentioned in #72.
    arp242 committed Aug 3, 2022
    Copy the full SHA
    922bbaa View commit details
    Browse the repository at this point in the history