Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.5.0 prep #380

Merged
merged 1 commit into from Aug 18, 2021
Merged

v1.5.0 prep #380

merged 1 commit into from Aug 18, 2021

Conversation

Code0x58
Copy link
Contributor

@Code0x58 Code0x58 commented Aug 2, 2021

After #289 is merged this could be merged and tagged (maybe with a new date)

CHANGELOG.md Outdated Show resolved Hide resolved
.mailmap Show resolved Hide resolved
nathany
nathany previously approved these changes Aug 4, 2021
@nshalman
Copy link
Contributor

Is it worth trying to get #371 into shape and landed as part of v1.5.0?
Presumably it would need to be updated to include the functionality of #289?
Thoughts?

@nathany nathany mentioned this pull request Aug 18, 2021
@Code0x58 Code0x58 force-pushed the v1.5.0-prep branch 2 times, most recently from 72b576d to d51ee3d Compare August 18, 2021 22:30
@nathany
Copy link
Contributor

nathany commented Aug 18, 2021

@nshalman Let's do FEN as a separate 1.6.0 release

CHANGELOG.md Outdated Show resolved Hide resolved
@Code0x58
Copy link
Contributor Author

I've updated this and set the date for Friday, but could merge it sooner or later as it will require an approval first. Once this is merged it should just be a case of tagging (hopefully I can do that).

I agree with the 1.6.0 being separate, it's probably good to release more frequently.

@Code0x58 Code0x58 merged commit 08848a0 into fsnotify:master Aug 18, 2021
@Code0x58 Code0x58 deleted the v1.5.0-prep branch August 18, 2021 22:48
@nathany
Copy link
Contributor

nathany commented Aug 18, 2021

@Code0x58 You should be able to tag a release. Did you clone fsnotify/fsnotify or are you still working from the fork?

Or try creating a tag/release from here: https://github.com/fsnotify/fsnotify/releases

Thanks

@Code0x58
Copy link
Contributor Author

v1.5.0 is pushed and additionally marked as a release on GitHub, so any watchers will be notified.

@nathany
Copy link
Contributor

nathany commented Aug 18, 2021

Perfect. Thanks!

ianyh pushed a commit to PreVeil/fsnotify that referenced this pull request Jan 19, 2022
* introduce GitHub Actions

* Add lint+vet+old versions to GitHub Action

* Remove Travis CI and references

* Drop support/testing for Go 1.11 and earlier (fsnotify#381)

* Update x/sys to latest (fsnotify#379)

* add //go:build lines + add 1.17.0-rc2 to test matrix (fsnotify#377)

* Update test matrix for go 1.17 stable release (fsnotify#385)

* Add AddRaw to not follow symlinks + Fix link folloing on Windows (fsnotify#289)

* v1.5.0 preparation (fsnotify#380)

* revise pull request template

* Revert "Add AddRaw to not follow symlinks + Fix link folloing on Windows (fsnotify#289)"

This reverts commit e2e9517.

* prepare 1.5.1, retract 1.5.0

* Removed dead link

* Update issue templates (fsnotify#410)

* Update issue templates

* remove old issue template

* Test on Go 1.18 and two most recent versions (fsnotify#411)

* Test on Go 1.18 and two most recent versions

* on push

* ci

* update readme

* revise contributing

* maintainers wanted

* Final Notice: Maintainers Wanted

* fix go vet warnings: call to (*T).Fatalf from a non-test goroutine (fsnotify#416)

* made the changes related to recursive directory check

* made changes in window.go for buffer size

* DA-992: Pair windows' delete + create event to generate a rename event (#1)

* made the changes related to recursive directory check

* made changes in window.go for buffer size

* added the oldname attribute

* old name added to rename event, one event is generated for rename

* added oldname in printing rename events

* tests for checking  the oldName attr for rename added

* create fsnotify event added

* input to create event changed

* create fsnotify event function modified

* ID added

* logs added

* added create fsnotify event in inotify

* logs added

* prints added

* reviews

* reviews addressed

* Hangkun/da 992/window rename event (#2)

* Let's begin

* Add getpath

* Init test workflow

* 1.40.0 exits?

* Linter fix

* asdf

* 100

Co-authored-by: hu13 <hangkun@preveil.com>

* Clean up unused

* Badge

Co-authored-by: Hangkun Ung <hangkun.ung@gmail.com>
Co-authored-by: hu13 <hangkun@preveil.com>

* Rebase upstream fixes

* Rename bundle only works on windows

* Update CI golang

Co-authored-by: Ichinose Shogo <shogo82148@gmail.com>
Co-authored-by: Oliver Bristow <evilumbrella+github@gmail.com>
Co-authored-by: Nahum Shalman <nahamu@gmail.com>
Co-authored-by: Nathan Youngman <4566+nathany@users.noreply.github.com>
Co-authored-by: Loïc Vernet <vernet.loic@gmail.com>
Co-authored-by: Nathan Youngman <git@nathany.com>
Co-authored-by: paris <pariya.b@gmail.com>
Co-authored-by: hu13 <hangkun@preveil.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants