New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a feature to return the directories and files that are being monitored #374
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks appropriate and tested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution.
Unfortunately we can't add a new WatchList()
API that only works on Linux.
fsnotify
is a cross-platform library. If we want to add WatchList()
, it must also be added for macOS/BSD (kqueue) and Windows.
@NitroCao Would you update this? |
Hi, is this feature comming? |
Sorry for the long delay. Just added support for bsd and windows platforms. |
@nathany do you have opinion others? |
LGTM |
Looks like there is a problem with Hound |
I removed Hound and the branch protection rule that required it. |
So can we merge this PR now? |
Thank you |
thanks @mattn I see there is a 1.5.3 tag that was created before the 1.5.2 tag for this. Will that cause problems getting this update? |
OpenBSD build was broken since before. #443 |
What does this pull request do?
Add a method for
Watcher
to return the directories and files that are being monitored.Where should the reviewer start?
WatchList
method ininotify.go
.How should this be manually tested?
unit testing in
inotify_test.go
.