Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Solaris FEN using EventPorts from x/sys/unix #371

Merged
merged 61 commits into from Oct 13, 2022
Merged

Add Solaris FEN using EventPorts from x/sys/unix #371

merged 61 commits into from Oct 13, 2022

Commits on Jan 17, 2022

  1. Add Solaris FEN using EventPorts from x/sys/unix

    @nshalman
    nshalman committed Jan 17, 2022
    Copy the full SHA
    e374e19 View commit details
    Browse the repository at this point in the history

  2. GitHub Action to run illumos tests in a VM

    @nshalman
    nshalman committed Jan 17, 2022
    Copy the full SHA
    96066fd View commit details
    Browse the repository at this point in the history

  3. XXX squashme: fixups

    @nshalman
    nshalman committed Jan 17, 2022
    Copy the full SHA
    2226f96 View commit details
    Browse the repository at this point in the history

  4. XXX squashme: remove doneResp channel - doesn't break tests...

    @nshalman
    nshalman committed Jan 17, 2022
    Copy the full SHA
    1fbfcc9 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2022

  1. XXX squashme: send all fsnotify events found in the event ports event

    @nshalman
    nshalman committed Jan 18, 2022
    Copy the full SHA
    cf84108 View commit details
    Browse the repository at this point in the history

  2. XXX squashme: select -> if

    @nshalman
    nshalman committed Jan 18, 2022
    Copy the full SHA
    546c36c View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2022

  1. XXX squashme: handle merged MODIFIED and ATTRIB events

    @nshalman
    nshalman committed Jan 19, 2022
    Copy the full SHA
    d3c741d View commit details
    Browse the repository at this point in the history

  2. fix changelog

    @nshalman
    nshalman committed Jan 19, 2022
    Copy the full SHA
    acb22e2 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into fen-v2

    @nshalman
    nshalman committed Jan 19, 2022
    Copy the full SHA
    f10ecda View commit details
    Browse the repository at this point in the history

  4. ugprade golang.org/x/sys to latest

    @nshalman
    nshalman committed Jan 19, 2022
    Copy the full SHA
    e19ca77 View commit details
    Browse the repository at this point in the history

  5. add solaris and illumos cross-compilation builds

    @nshalman
    nshalman committed Jan 19, 2022
    Copy the full SHA
    5454809 View commit details
    Browse the repository at this point in the history

  6. illumos tests: run 10 times 

    If we're paying for a 15 minute wait to spin up the test VM
run the tests multiple times to get some extra confidence out
of it at the cost of another minute
    @nshalman
    nshalman committed Jan 19, 2022
    Copy the full SHA
    7b89a96 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2022

  1. Fix FEN

    @nshalman
    nshalman committed Jan 20, 2022
    Copy the full SHA
    04e3205 View commit details
    Browse the repository at this point in the history

  2. Integration Tests: change 1ms sleeps to 50ms 

    When testing the FEN code repeatedly and under
system load I can sometimes get these tests to fail
with a missed WRITE event. With these longer sleeps
I have been unable to produce any test failures.
    @nshalman
    nshalman committed Jan 20, 2022
    Copy the full SHA
    8b33f88 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into fen-v2

    @nshalman
    nshalman committed Jan 20, 2022
    Copy the full SHA
    03df8a8 View commit details
    Browse the repository at this point in the history

  4. make it a const

    @nshalman
    nshalman committed Jan 20, 2022
    Copy the full SHA
    bb0549e View commit details
    Browse the repository at this point in the history

  5. run slow tests automatically on pushes to main as a backstop of last … 

    …resort
    @nshalman
    nshalman committed Jan 20, 2022
    Copy the full SHA
    deef205 View commit details
    Browse the repository at this point in the history

  6. Revert "Integration Tests: change 1ms sleeps to 50ms" 

    This reverts commit 8b33f88.
    @nshalman
    nshalman committed Jan 20, 2022
    Copy the full SHA
    c375f66 View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'origin/main' into fen-v2

    @nshalman
    nshalman committed Jan 20, 2022
    Copy the full SHA
    e541566 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2022

  1. More fixups 

    This code depends on improvements in https://go-review.googlesource.com/c/sys/+/380034/
That haven't landed yet.
    @nshalman
    nshalman committed Jan 30, 2022
    Copy the full SHA
    12c8a00 View commit details
    Browse the repository at this point in the history

  2. integration tests: slight consistency improvement

    @nshalman
    nshalman committed Jan 30, 2022
    Copy the full SHA
    2d884f3 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into fen-v2

    @nshalman
    nshalman committed Jan 30, 2022
    Copy the full SHA
    3db872f View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2022

  1. bump illumos-vm action

    @nshalman
    nshalman committed Feb 1, 2022
    Copy the full SHA
    5f7091a View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2022

  1. Update x/sys/unix 

    Pull in https://go-review.googlesource.com/c/sys/+/380034 for solaris/illumos
    @nshalman
    nshalman committed Mar 28, 2022
    Copy the full SHA
    6021573 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2022

  1. Merge branch 'main' into fen-v2

    @arp242
    arp242 committed Aug 1, 2022
    Copy the full SHA
    62fed86 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2022

  1. add more t.Helper() to get to the right general area in the test files.

    @nshalman
    nshalman committed Aug 2, 2022
    Copy the full SHA
    0da5b8d View commit details
    Browse the repository at this point in the history

  2. solaris sometimes acts like windows

    @nshalman
    nshalman committed Aug 2, 2022
    Copy the full SHA
    4d18cec View commit details
    Browse the repository at this point in the history

  3. solaris sometimes acts like linux

    @nshalman
    nshalman committed Aug 2, 2022
    Copy the full SHA
    401f603 View commit details
    Browse the repository at this point in the history

  4. bug in fen? I don't know why this is happening

    @nshalman
    nshalman committed Aug 2, 2022
    Copy the full SHA
    f329a9a View commit details
    Browse the repository at this point in the history

  5. bug in fen? I don't know why this is happening

    @nshalman
    nshalman committed Aug 2, 2022
    Copy the full SHA
    9ac8346 View commit details
    Browse the repository at this point in the history

  6. fix typo

    @nshalman
    nshalman committed Aug 2, 2022
    Copy the full SHA
    532460e View commit details
    Browse the repository at this point in the history

  7. test helper: make solaris and illumos synonyms

    @arp242
    arp242 committed Aug 2, 2022
    Copy the full SHA
    f8f708c View commit details
    Browse the repository at this point in the history

  8. Fix testcase

    @arp242
    arp242 committed Aug 2, 2022
    Copy the full SHA
    e6d3c16 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2022

  1. small cleanup of eventBits and call to AssociatePath

    @nshalman
    nshalman committed Aug 4, 2022
    Copy the full SHA
    58d1748 View commit details
    Browse the repository at this point in the history

  2. solaris: only watch the contents of directories explicitly added

    @nshalman
    nshalman committed Aug 4, 2022
    Copy the full SHA
    bb59fed View commit details
    Browse the repository at this point in the history

  3. solaris: remove races on Close

    @nshalman
    nshalman committed Aug 4, 2022
    Copy the full SHA
    6f5aebd View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/main' into fen-v2 

    Conflicts:
	README.md
    @nshalman
    nshalman committed Aug 4, 2022
    Copy the full SHA
    5350981 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2022

  1. Merge branch 'main' into fen-v2

    @arp242
    arp242 committed Aug 6, 2022
    Copy the full SHA
    d1b9589 View commit details
    Browse the repository at this point in the history

  2. Clarify that Oracle™® Solaris™® is currently untested

    @arp242
    arp242 committed Aug 6, 2022
    Copy the full SHA
    91a0d03 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into fen-v2

    @arp242
    arp242 committed Aug 6, 2022
    Copy the full SHA
    6c4e73f View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2022

  1. Merge remote-tracking branch 'origin/main' into fen-v2 

    Also some fixups in backend_fen.go

Conflicts:
	integration_test.go
    @nshalman
    nshalman committed Aug 9, 2022
    Copy the full SHA
    c8f45c7 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2022

  1. solaris test tweaks

    @nshalman
    nshalman committed Aug 10, 2022
    Copy the full SHA
    2811cad View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fen-v2

    @arp242
    arp242 committed Aug 10, 2022
    Copy the full SHA
    da1e80a View commit details
    Browse the repository at this point in the history

  3. Fix indent (gofmt) 

    gofmt uses tabs, rather than spaces for indents.
    @arp242
    arp242 committed Aug 10, 2022
    Copy the full SHA
    6ad9eba View commit details
    Browse the repository at this point in the history

  4. Try to kick off the CI

    @arp242
    arp242 committed Aug 10, 2022
    Copy the full SHA
    73ce130 View commit details
    Browse the repository at this point in the history

  5. "Fix" (new) testcase 

    Seems like the watcher gets lost if the watched file gets renamed, just
as with kqueue. It's not a big deal as such because it's been broken in
kqueue since forever; should fix it, but for now just adjusting the test
is fine.
    @arp242
    arp242 committed Aug 10, 2022
    Copy the full SHA
    6f261e6 View commit details
    Browse the repository at this point in the history

  6. Add internal.Debug() for illumos too

    @arp242
    arp242 committed Aug 10, 2022
    Copy the full SHA
    79d9424 View commit details
    Browse the repository at this point in the history

  7. Few small changes for clarity

    @arp242
    arp242 committed Aug 10, 2022
    Copy the full SHA
    33df526 View commit details
    Browse the repository at this point in the history

  8. Add TestRemoveState() for FEN too 

    This also actually fixed up a mistake I made in 33df526 in removing the
switches 😅 It would no longer return the error.
    @arp242
    arp242 committed Aug 10, 2022
    Copy the full SHA
    96d8c26 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' into fen-v2

    @arp242
    arp242 committed Aug 10, 2022
    Copy the full SHA
    b9e7edc View commit details
    Browse the repository at this point in the history

  10. Run ./mkdoc.zsh

    @arp242
    arp242 committed Aug 10, 2022
    Copy the full SHA
    0f85e13 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2022

  1. Merge remote-tracking branch 'nshalman/fen-v2' into fen-v2

    @nshalman
    nshalman committed Aug 11, 2022
    Copy the full SHA
    fbe9413 View commit details
    Browse the repository at this point in the history

  2. solaris: fixes and thoughts 

    I noticed an odd behavior when I ran:
go run ./cmd/fsnotify watch /tmp/ & sleep 1; mkdir /tmp/foo ; touch /tmp/foo/bar; sleep 1; rm -r /tmp/foo ; fg

At first I just got errors, then I fixed it part way and saw a WRITE on
the removed directory. Now I see a REMOVE.
    @nshalman
    nshalman committed Aug 11, 2022
    Copy the full SHA
    0b29427 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2022

  1. Merge remote-tracking branch 'origin/main' into fen-v2

    @nshalman
    nshalman committed Sep 8, 2022
    Copy the full SHA
    68dc7e7 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2022

  1. fen cleanups: ioutil, LStat vs Stat 

    Replace deprecated use of ioutil
During even processing, use LStat, but Stat explicitly watched symlinks
Make event bit checking more succinct
    @nshalman
    nshalman committed Sep 11, 2022
    Copy the full SHA
    a49818b View commit details
    Browse the repository at this point in the history

  2. fen: address some TODOs

    @nshalman
    nshalman committed Sep 11, 2022
    Copy the full SHA
    bdcc473 View commit details
    Browse the repository at this point in the history

  3. fen: fix handling of explicitly watched symlinks

    @nshalman
    nshalman committed Sep 11, 2022
    Copy the full SHA
    60b7185 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2022

  1. illumos: test on go 1.19

    @nshalman
    nshalman committed Sep 14, 2022
    Copy the full SHA
    cad1bd8 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2022

  1. Merge remote-tracking branch 'origin/main' into fen-v2

    @nshalman
    nshalman committed Sep 16, 2022
    Copy the full SHA
    2daef9a View commit details
    Browse the repository at this point in the history

  2. TestWatchRename/re-add_renamed_file: fen behaves like kqueue

    @nshalman
    nshalman committed Sep 16, 2022
    Copy the full SHA
    996e478 View commit details
    Browse the repository at this point in the history

  3. explicit alias of 'fen' for solaris and illumos similar to kqueue

    @nshalman
    nshalman committed Sep 16, 2022
    Copy the full SHA
    9dcb6e2 View commit details
    Browse the repository at this point in the history