Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TravisCI: bump Go versions #350

Closed
wants to merge 1 commit into from
Closed

TravisCI: bump Go versions #350

wants to merge 1 commit into from

Conversation

fhs
Copy link

@fhs fhs commented Nov 10, 2020

This fixes the CI. Builds were failing because go.mod file wasn't
being used on older Go versions on macOS. This led to using the wrong
version of golang.org/x/sys/unix. See for example:
https://travis-ci.org/github/fsnotify/fsnotify/builds/742594311

Copy link

@PaluMacil PaluMacil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems correct to me. I think this version bump is good

PaluMacil
PaluMacil previously approved these changes Feb 5, 2021
Copy link

@PaluMacil PaluMacil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good; please merge. No concerns

@kolyshkin
Copy link
Contributor

This needs to be updated to add 1.15 and drop 1.12.

This fixes the CI. Builds were failing because `go.mod` file wasn't
being used on older Go versions on macOS. This led to using the wrong
version of `golang.org/x/sys/unix`. See for example:
https://travis-ci.org/github/fsnotify/fsnotify/builds/742594311
@fhs
Copy link
Author

fhs commented Feb 6, 2021

This needs to be updated to add 1.15 and drop 1.12.

Done

@kolyshkin
Copy link
Contributor

@fhs thank you!

Frankly speaking, we need to switch away from travis (which is going to be retired real soon now, see travis-ci.org). I found that github actions is currently a good alternative.

I'd prepare a PR, but alas this repo seems abandoned (see e.g. #260).

@fhs
Copy link
Author

fhs commented Feb 6, 2021

ping @fsnotify, @nathany

@nathany
Copy link
Contributor

nathany commented Jan 14, 2022

We've switched to GitHub Actions. Thanks for the contribution

@nathany nathany closed this Jan 14, 2022
@fhs fhs deleted the ci branch January 14, 2022 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants