Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on Plan 9 #349

Closed
wants to merge 3 commits into from
Closed

Fix build on Plan 9 #349

wants to merge 3 commits into from

Conversation

fhs
Copy link

@fhs fhs commented Nov 10, 2020

This fixes build for programs that import fsnotify but fsnotify is not
absolutely necessary for the program to be useful.

What does this pull request do?

Fixes build on Plan 9.

Where should the reviewer start?

plan9.go

How should this be manually tested?

GOOS=plan9 go build

PaluMacil
PaluMacil previously approved these changes Feb 5, 2021
Copy link

@PaluMacil PaluMacil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems sensible and safe to merge

fhs and others added 2 commits July 21, 2022 13:50
This fixes build for programs that import fsnotify but fsnotify is not
absolutely necessary for the program to be useful.
@arp242
Copy link
Member

arp242 commented Jul 21, 2022

#424 made this one superfluous: it does the same for all unsupported systems (including Plan 9).

@arp242 arp242 closed this Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants