Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add polling fallback #326

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add polling fallback #326

wants to merge 1 commit into from

Conversation

Helflym
Copy link

@Helflym Helflym commented Feb 20, 2020

Polling fallback can be used by operating systems without any internal
mechanism to watch files. This is only use on AIX for now, but should
work on every over OS (tested on Linux).

polling.go Outdated Show resolved Hide resolved
polling.go Outdated Show resolved Hide resolved
@Helflym
Copy link
Author

Helflym commented Feb 27, 2020

Any news about this CL ? I need it for other go packages.

Polling fallback can be used by operating systems without any internal
mechanism to watch files. This is only use on AIX for now, but should
work on every over OS (tested on Linux).
@ncerny
Copy link

ncerny commented Sep 24, 2020

I need this as well. Do we have any update on this PR?

@cobolbaby
Copy link

cobolbaby commented Nov 10, 2020

@Helflym If the number of subdirectories in the monitored directory exceeds 100k, do you need to reconsider the implementation of the function and make directory traversal as efficient as possible.

@Helflym
Copy link
Author

Helflym commented Nov 12, 2020

@Helflym If the number of subdirectories in the monitored directory exceeds 100k, do you need to reconsider the implementation of the function and make directory traversal as efficient as possible.

This implementation was made in order to enable fsnotify on AIX, but it's clearly not optimized. I haven't made any performance metrics but I guess it won't work very well with more than 100k directories.
If you wish to provide an optimized version, go on. I, personally, don't have time to do so for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants