Add inotify CLOSE events #298
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inotify notifies when files have finished being written to. To reliably detect if a write to a file has finished the event necessary is CLOSE_WRITE.
|
Sorry, but adding new events that only work on Linux and don't do anything on the other supported platforms isn't a great solution. If you have some ideas, please discuss on #22. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inotify notifies when files have finished being written to. To reliably
detect if a write to a file has finished the event necessary is
CLOSE_WRITE.
What does this pull request do?
Adds CLOSE_WRITE and CLOSE_NOWRITE support for linux
Where should the reviewer start?
How should this be manually tested?
On a Linux machine you can just copy a file into a folder. Close will be triggered even when a file is not changed.
Update will only trigger when a write was recently finished.