Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#234] t.Fatalf -> t.Errorf in go routines #266

Merged
merged 2 commits into from Aug 30, 2018
Merged

[#234] t.Fatalf -> t.Errorf in go routines #266

merged 2 commits into from Aug 30, 2018

Commits on Aug 30, 2018

  1. [#234] t.Fatalf -> t.Errorf in go routines 

    The documentation for t.FailNow (which is called by t.Fatalf) states
that it should not be called in go routines outside of the test go
routine.
    @gdey
    gdey committed Aug 30, 2018
    Copy the full SHA
    8c10b70 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into redo_234

    @gdey
    gdey committed Aug 30, 2018
    Copy the full SHA
    54ffeec View commit details
    Browse the repository at this point in the history