Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if channels are closed in the example #244

Merged
merged 3 commits into from Aug 30, 2018
Merged

Check if channels are closed in the example #244

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
135d0ae
Check if channels are closed in the example
alexeykazakov May 1, 2018
f490303
Check if the channels are closed before printing
alexeykazakov May 1, 2018
e15902b
Merge branch 'master' into docs
matthias-stone Aug 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 8 additions & 2 deletions example_test.go
View file
Open in desktop
Expand Up @@ -23,13 +23,19 @@ func ExampleNewWatcher() {
go func() {
for {
select {
case event := <-watcher.Events:
case event, ok := <-watcher.Events:
log.Println("event:", event)
if event.Op&fsnotify.Write == fsnotify.Write {
log.Println("modified file:", event.Name)
}
case err := <-watcher.Errors:
if !ok {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the ok before reading from the event. Essentially, this needs to happen before line 27.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right :)
Fixed.

return
}
case err, ok := <-watcher.Errors:
log.Println("error:", err)
if !ok {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above, check for close before reading the error. :)

return
}
}
}
}()
Expand Down