Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestInotifyOverflow fails on arm64 #253

Closed
anthonyfok opened this issue Jul 15, 2018 · 5 comments
Closed

TestInotifyOverflow fails on arm64 #253

anthonyfok opened this issue Jul 15, 2018 · 5 comments

Comments

@anthonyfok
Copy link

anthonyfok commented Jul 15, 2018

Which operating system (GOOS) and version are you using?

$ lsb_release -a
No LSB modules are available.
Distributor ID:	Debian
Description:	Debian GNU/Linux unstable (sid)
Release:	unstable
Codename:	sid

Please describe the issue that occurred.

The Ubuntu Autopkgtest CI reveals that golang-fsnotify v1.4.7 has always failed at TestInotifyOverflow on arm64, but OK on all other tested architectures:

See:

Are you able to reproduce the issue? Please provide steps to reproduce and a code sample if possible.

I was able to reproduce this on my Raspberry Pi 3 running Debian arm64:

$ go get -v -u github.com/fsnotify/fsnotify
$ cd ~/go/src/github.com/fsnotify/fsnotify
$ go test -run TestInotifyOverflow -v ./...
=== RUN   TestInotifyOverflow
--- FAIL: TestInotifyOverflow (58.65s)
	inotify_test.go:422: Not done
FAIL
FAIL	github.com/fsnotify/fsnotify	58.671s

(Thinking out loud: I wonder if the test taking over 58 seconds is normal or not. For comparison, the same test takes 6.01s on my amd64 laptop, 26.48s on armhf (Ubuntu Autopkgtest), 5.30s on ppc64el, 5.09s on s390x... oh, 25.04s on arm64 on Ubuntu Autopkgtest, which is on par with armhf... okay...)

@matthias-stone
Copy link
Contributor

Hey Anthony! I think I fixed this as part of PR #265, can you verify that this is resolved for master for you?

@anthonyfok
Copy link
Author

Thank you so much, Matthias!
I will find time test this out next week. (Suddenly too many unexpected tasks landed in my lap past few days.)

@QuLogic
Copy link

QuLogic commented Feb 5, 2019

I'm not sure that #265 fixes it everywhere. I saw that our package was failing on aarch64 and s390x, so I backported #265 and built again. Unfortunately, it still fails on s390x.

@QuLogic
Copy link

QuLogic commented Mar 3, 2019

We've since updated from Go 1.12beta2 to the final 1.12, and it appears the failure on s390x is fixed now.

@matthias-stone
Copy link
Contributor

@QuLogic Awesome! I'm going to mark this as closed, and if someone re-encounters a similar issue they can open a new bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants