Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builders for continuous integration #136

Closed
nathany opened this issue Apr 20, 2016 · 7 comments · Fixed by #528
Closed

Builders for continuous integration #136

nathany opened this issue Apr 20, 2016 · 7 comments · Fixed by #528

Comments

@nathany
Copy link
Contributor

nathany commented Apr 20, 2016

The combination of TravisCI (Linux/OS X) and AppVeyor (Windows) is not enough.

v1.3.0 was patched for linux/arm64, but we have no CI for arm64 to ensure that it keeps on working. We need a more comprehensive solution that covers arm64, ppc, and Solaris.

The best bet is to look into the Builders used by Go itself.
https://github.com/golang/go/wiki/DashboardBuilders

Perhaps one option would be to ask the Go Team if fsnotify could become a golang.org/x/fsnotify subrepository, but maybe that isn't necessary.

Of note, there still could be API changes that warrant a v2.0 of fsnotify.

@nathany
Copy link
Contributor Author

nathany commented Apr 20, 2016

As far as local testing, I currently use https://github.com/nathany/vagrant-gopher for BSD and Linux, which I run on a Mac along with a Windows 10 VM in VMware Fusion. Solaris could probably be added, but that still only covers x86.

I recall some plans to make it possible to utilize the builders from a local computer while debugging issues, but I don't know where that is currently at.

@nathany
Copy link
Contributor Author

nathany commented Apr 20, 2016

From @bradfitz:

Currently our builders can only run stuff in golang.org/x* and hosted on Gerrit.
That's not fundamental, but it's just how things are currently implemented.

I will compose a message to golang-dev tonight after work to see where the community wants to take this.

@nathany
Copy link
Contributor Author

nathany commented Apr 20, 2016

There is also a matter of where the issue tracking is done in the future. In a subrepo or the Go language repo. The change from pull requests to CLs.

I'm fairly happy with GitHub's recent improvements to pull requests and my own workflows using hub, so it's really just the builders that we need to get going on.

@bradfitz
Copy link

I've also been working to make Github pull requests auto-convert into Gerrit reviews. (https://github.com/LetsUseGerrit/)

@nathany
Copy link
Contributor Author

nathany commented Apr 21, 2016

Posted to golang-dev to include other Go contributors in the discussion. https://groups.google.com/forum/#!topic/golang-dev/SVrNHQU1oEM

@nathany
Copy link
Contributor Author

nathany commented Oct 5, 2016

Opened an issue over in the Go repository. golang/go#17312

@anthonyfok
Copy link

anthonyfok commented Jul 15, 2018

Hi Nathan,

Ubuntu runs an autopkgtest CI, with arm64 included, here:

Granted, it is run only after when we upload a new Debian package for golang-fsnotify, but I think it does help, I think, because it reveals that one of the tests have always failed on arm64!

=== RUN   TestInotifyOverflow
--- FAIL: TestInotifyOverflow (58.47s)
	inotify_test.go:422: Not done

(TestInotifyOverflow failing on arm64 has been filed as #253.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants