New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintainers wanted #183
Comments
I've setup GitHub teams for each platform. If you have already contributed to fsnotify and would like to be added to a platform-specific team, please let myself or another maintainer know. |
@nathany Hi, BTW, I would like to confirm just in case,
Is It means like that?
If so and if we want to cross-platform project using fs watcher, Do we will need to import each platform packages to |
@zchee Initially I'm thinking we build up repositories for https://github.com/fsnotify/inotify, etc. independent of the fsnotify package. Then start replacing the low-level bits of the fsnotify package with dependencies on those, while maintaining the same cross-platform API. Eventually we can also substitute kqueue for fsevents on darwin. If you'd like to help out, take a look at the https://github.com/fsnotify/fsevents project. There is an open issue with some next steps there, and I'm sure there's much more to do. |
@nathany Ah, I see. Thanks. Anyway, Apple has been announced |
I like the idea but I am not sure how closely linux and windows interfaces are ? |
They are quite different. Right now I'm not thinking of changing the API of fsnotify. Just keep it stable for users. If we can separate the code into low-level bits and high-level bits, I think it will be easier to maintain, as separate teams of people will be able to focus on each platform, with one team on cross-platform concerns. Not sure if I'm explaining it well, it might be easier to show than explain. I've already started with kqueue, where the code from line 463 on is the low level part. https://github.com/fsnotify/fsnotify/blob/master/kqueue.go#L463. I'm thinking of putting that in a separate repo with a test suite and documentation and making that into it's own library that fsnotify depends on. Still many details to work out though -- and certainly open to other ideas. |
@nathany Ah, it's for me? If so, I totally understood. Yes, API compatibility is very important. and I like your idea. I incorrectly wrote it. Not "add" an API to the fsnotify. |
I could still really use some help to maintain fsnotify. Code reviews, testing and merging PRs, doing releases. |
Clearly I have been doing a poor job of maintaining fsnotify. Issues without answers, pull requests left open for months... progress has stalled not due to lack of contributors, but because I am currently the bottleneck. When I got involved with Chris Howey's fsnotify, it was to help out with the API. I don't have the experience and knowledge of file systems necessary to vet a pull request like #124, which adds epoll to kqueue. Much less take on a whole new platform like #196. At first I thought I would learn these things, but doing so hasn't been a priority in what spare time I do have. I had hoped that having a generous policy (#126) for granting commit access combined with this call for maintainers would see a team of people volunteer to help maintain fsnotify. I had high hopes for splitting responsibility by operating system to make maintenance more palatable. But that hasn't happened... and I don't know what needs to be done for that to happen. At this point, I am tired of feeling guilty for not being more involved in the project. I'm also tired of worrying that merging a pull request will break an upstream like Docker or a platform that isn't under CI (#136). I haven't been very involved lately, so it's time to make it official. I'm stepping away from the fsnotify project. It's up to you now. If you need something from me during the transition, reach out to me here or on #fsnotify on Slack. Good luck. |
@nathany Hi, Sorry for my pull request was related the CI only. But I'll more learn the file-systems, and I will make an effort to contribute to the linux side(if possible). I'll do my best. |
@nathany Thanks for all of your work! You've done a great job running this
project, and coaxed contributions from many people (including myself), and
found a way to piece them all together. You deserve thanks from all the
many people who have benefitted. Good luck with whatever you do next!
Sam
…On Wed, Mar 15, 2017 at 10:36 AM, Koichi Shiraishi ***@***.*** > wrote:
@nathany <https://github.com/nathany> Hi,
Just one thing, I just wanna tell you that you did the job is not poor.
The community(and Member) management, raise a problem of members shortage
is very hard works.
Sorry for my pull request was related the CI only. But I'll more learn the
file-systems, and I will make an effort to contribute to the linux side(if
possible). I'll do my best.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#183 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABMJvdHHp0Bfkeaf6u9w0A65fqnsMbS1ks5rlwhagaJpZM4KgPzl>
.
|
If you're planning to be at GopherCon in Denver next week, and if you have been helping or would like to help maintain fsnotify, let's plan to meet on Community Day. |
I can step up as a maintainer.
|
@kolyshkin Thanks Kir. That would be really helpful. Even just to have someone focused on the inotify portion and to help triage pull requests and issues. Cross-platform experience is only necessary if we want to change the API. |
There's a call for gophers to help here: gofrs/help-requests#15 |
Relating to my work on #371 I am open to becoming a maintainer for the FEN support for solaris/illumos. |
@nshalman Thanks! Invite sent. |
Hi @nathany Do you still need help maintaining |
@Lumexralph Yes It's a challenging project, to be sure, being a cross-platform API to unify disparate APIs makes it tricky. |
My call for help maintaining fsnotify has had very little result in the past 5 years. I will be officially leaving the If nobody else takes the project over soon, I will be archiving the project. That way it can still be used as-is but no more issues can be reported. |
There are a lot of open issues, and a lot of them are duplicates. I've updated the issue template to hopefully cut down on future duplicates, but someone still needs to reply to existing issues. Better documentation may also help preemptively answer questions that people keep reporting issues for again and again. |
replaced issue with #413 |
I think it makes sense to split fsnotify out into smaller platform-specific libraries that fsnotify (or alternatives) can use. Each library needs maintainers to go off and create the library with integration tests and documentation, and to handle issues and code reviews on an ongoing basis.
Are you interested?
related: https://github.com/pickhardt/maintainers-wanted
letter posted to forum: https://groups.google.com/forum/#!topic/golang-nuts/Ix4sg_gDLNE
The text was updated successfully, but these errors were encountered: