Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: propagate async context #199

Merged
merged 2 commits into from Apr 3, 2018
Merged

fix: propagate async context #199

merged 2 commits into from Apr 3, 2018

Commits on Feb 23, 2018

  1. fix: propagate async context 

    Start with Nan 2.9.0 certain varaiants of Nan::Callback::Call are
deprecated. Overloads that preserve the async context are preferred
instead.

We associate a Nan::AsyncResource corresponding to a FSEvents instance.
This captures the async execution context which is restored when the
async callback is called.

For more information see https://github.com/nodejs/nan/blob/HEAD/doc/node_misc.md#nanasyncresource.
    @ofrobots
    ofrobots committed Feb 23, 2018
    Copy the full SHA
    3925761 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2018

  1. stop building against Node 0.12 

    With new enough compilers, V8 headers corresponding to 0.12 no longer
compile. For more details see
https://github.com/nodejs/nan#compiling-against-nodejs-012-on-osx
    @ofrobots
    ofrobots committed Feb 24, 2018
    Copy the full SHA
    34da631 View commit details
    Browse the repository at this point in the history