Replace FactoryGirl with FactroyBot

FactoryGirl was recently renamed to FactoryBot, and we should of course switch to keep getting updates.

Gemfile

@@ -70,7 +70,7 @@ group :development, :test do
   gem 'capistrano-rbenv', require: false
   gem 'capistrano-passenger', require: false
   gem 'capybara'
-  gem 'factory_girl_rails'
+  gem 'factory_bot_rails'
   gem 'dotenv-rails'
   gem 'poltergeist'
   gem 'pry-byebug'

Gemfile.lock

@@ -187,10 +187,10 @@ GEM
     erubi (1.7.1)
     erubis (2.7.0)
     execjs (2.7.0)
-    factory_girl (4.8.0)
+    factory_bot (4.8.2)
       activesupport (>= 3.0.0)
-    factory_girl_rails (4.8.0)
-      factory_girl (~> 4.8.0)
+    factory_bot_rails (4.8.2)
+      factory_bot (~> 4.8.2)
       railties (>= 3.0.0)
     ffi (1.9.23)
     font-awesome-rails (4.7.0.3)
@@ -483,7 +483,7 @@ DEPENDENCIES
   devise_token_auth
   dotenv-rails
   ejs
-  factory_girl_rails
+  factory_bot_rails
   font-awesome-rails
   foreman
   fotoramajs

lib/tasks/tests_data.rake

@@ -128,8 +128,8 @@ namespace :db do
                              start_date: Time.zone.now, category: 'Nollning', end_date: Time.zone.now + 10.hours)
 
     # Documents
-    FactoryGirl.create(:document)
-    FactoryGirl.create(:document)
+    FactoryBot.create(:document)
+    FactoryBot.create(:document)
 
     # Categories
     Category.find_or_create_by!(title: 'Studier', slug: 'studie')

spec/factories/accesses.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :access do
     post
     door

spec/factories/adventure_groups.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :adventure_group do
     adventure
     group

spec/factories/adventures.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :adventure do
     title
     content { generate(:description) }

spec/factories/albums.rb

@@ -1,5 +1,5 @@
 # encoding: UTF-8
-FactoryGirl.define do
+FactoryBot.define do
   factory :album do
     title
     description

spec/factories/blog_posts.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :blog_post do
     title
     preamble { generate(:description) }

spec/factories/cafe_shifts.rb

@@ -1,5 +1,5 @@
 # encoding: UTF-8
-FactoryGirl.define do
+FactoryBot.define do
   factory :cafe_shift do
     pass 1
     lv 1

spec/factories/cafe_workers.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :cafe_worker do
     cafe_shift
     competition true

spec/factories/candidates.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :candidate do |c|
     association :election, semester: Post::AUTUMN
     association :post, semester: Post::AUTUMN

spec/factories/categories.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :category do
     title_sv { generate(:title) }
     title_en { "#{title_sv} - English" }

spec/factories/constants.rb

@@ -1,5 +1,5 @@
 #encoding: UTF-8
-FactoryGirl.define do
+FactoryBot.define do
   factory :constant do
     name
     value

spec/factories/contact_messages.rb

@@ -1,5 +1,5 @@
 # encoding: UTF-8
-FactoryGirl.define do
+FactoryBot.define do
   factory :contact_message do
     skip_create
     name 'Hilbert Älg'

spec/factories/contacts.rb

@@ -1,5 +1,5 @@
 # encoding: UTF-8
-FactoryGirl.define do
+FactoryBot.define do
   factory :contact do |c|
     name 'Spindelmän'
     email

spec/factories/councils.rb

@@ -1,5 +1,5 @@
 # encoding: UTF-8
-FactoryGirl.define do
+FactoryBot.define do
   factory :council do
     title
     url

spec/factories/documents.rb

@@ -1,5 +1,5 @@
 # encoding: UTF-8
-FactoryGirl.define do
+FactoryBot.define do
   factory :document do
     title
     pdf Rack::Test::UploadedFile.new(File.open('spec/assets/pdf.pdf'))

spec/factories/doors.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :door do
     title
     description

spec/factories/election_posts.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :election_post do
     election
     post

spec/factories/elections.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :election do
     title
     url

spec/factories/event_signups.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :event_signup do
     event
     slots 5

spec/factories/event_users.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :event_user do
     user
     user_type EventSignup::MEMBER

spec/factories/events.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :event do
     title_sv { generate(:title) }
     title_en { generate(:title) }

spec/factories/faq.rb

@@ -1,5 +1,5 @@
 # encoding: UTF-8
-FactoryGirl.define do
+FactoryBot.define do
   factory :faq do
     question { generate(:description) }
     answer { generate(:description) }

spec/factories/group_users.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :group_user do
     user
     group

spec/factories/groups.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :group do
     name
     number { rand(1..100) }

spec/factories/images.rb

@@ -1,8 +1,8 @@
 # encoding: UTF-8
-FactoryGirl.define do
+FactoryBot.define do
   factory :image do
     album
-    photographer { FactoryGirl.create(:user) }
+    photographer { FactoryBot.create(:user) }
     file Rack::Test::UploadedFile.new(File.open('spec/assets/image.jpg'))
     filename { generate(:firstname) }
   end

spec/factories/introductions.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :introduction do
     title_sv { generate(:title) }
     title_en { "English: #{title_sv}" }

spec/factories/mail_aliases.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :mail_alias do
     username 'mr_boss'
     domain 'fsektionen.se'

spec/factories/main_menu.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :main_menu do
     name
     index { rand(10..100) }

spec/factories/meetings.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :meeting do
     user
     start_date { 1.days.from_now }

spec/factories/menus.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :menu do
     name
     main_menu

spec/factories/news.rb

@@ -1,5 +1,5 @@
 # encoding: UTF-8
-FactoryGirl.define do
+FactoryBot.define do
   factory :news do
     title
     content { generate(:description) }

spec/factories/nominations.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :nomination do
     name
     email

spec/factories/notifications.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :notification do
     user
     seen false

spec/factories/page_elements.rb

@@ -1,5 +1,5 @@
 # encoding: UTF-8
-FactoryGirl.define do
+FactoryBot.define do
   factory :page_element do
     page
     index { rand(1..10) }

spec/factories/page_images.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :page_image do
     page
     image Rack::Test::UploadedFile.new(File.open('spec/assets/image.jpg'))

spec/factories/pages.rb

@@ -1,5 +1,5 @@
 # encoding: UTF-8
-FactoryGirl.define do
+FactoryBot.define do
   factory :page do
     url
     visible { true }

spec/factories/permission_posts.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :permission_post do
     permission
     post

spec/factories/permissions.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :permission do
     subject_class { ['News', 'CafeWork', 'Post', 'Rent', 'Event'].sample }
     action { ['read', 'create', 'update', 'manage', 'new'].sample }

spec/factories/post_users.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :post_user do
     post
     user

spec/factories/posts.rb

@@ -1,5 +1,5 @@
 # encoding: UTF-8
-FactoryGirl.define do
+FactoryBot.define do
   factory :post do
     title
     council

spec/factories/rents.rb

@@ -1,5 +1,5 @@
 # encoding: UTF-8
-FactoryGirl.define do
+FactoryBot.define do
 
   factory :rent do
     user

spec/factories/shared.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   sequence(:description) { |n| "This describes the most impressive nr#{n}" }
   sequence(:email) { |n| "d.wessman#{n}@fsektionen.se" }
   sequence(:lastname, 'A') { |n| "Wessman#{n}" }

spec/factories/short_links.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :short_link do
     link 'my_awesomeshort-link0'
     target 'http://randomwebpage.com:80/some/resource/yeah?q=asdf&yeah='

spec/factories/tool_rentings.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :tool_renting do
     renter 'Adrian Roth'
     purpose 'to use'

spec/factories/tools.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :tool do
     title 'Awesome Tool'
     description

spec/factories/users.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :user do
     email
     password '12345678'

spec/factories/work_posts.rb

@@ -1,5 +1,5 @@
 # encoding: UTF-8
-FactoryGirl.define do
+FactoryBot.define do
   factory :work_post do
     title
     description

spec/rails_helper.rb

@@ -23,7 +23,7 @@
   # arbitrary gems may also be filtered via:
   # config.filter_gems_from_backtrace("gem name")
 
-  config.include FactoryGirl::Syntax::Methods
+  config.include FactoryBot::Syntax::Methods
 
   # Allow for I18n in tests
   config.include AbstractController::Translation

spec/support/factory_girl.rb

@@ -1,4 +1,4 @@
-require 'factory_girl'
+require 'factory_bot'
 RSpec.configure do |config|
-  config.include FactoryGirl::Syntax::Methods
+  config.include FactoryBot::Syntax::Methods
 end