Use WeakMaps instead of ref for connect flags #946
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Try to fix a memory leak by changing the internal
connect
flags.Why:
Because those flags could be the source of a memory leak, as documented by @erdigokce here:
How:
Using
WeakMap
s instead ofref
s to annotate if a component has been mounted or if it was changed before mounting.Tasks:
Unrelated Tasks
Additional Comments