Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add server middlewares defined in packages to the Koa app #852

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

DAreRodz
Copy link
Member

What:

Get middlewares exposed by Frontity packages in the server property and register them into the Koa server.

Co-authored-by: @cristianbote

Why:

To close #696

Tasks:

  • Code
  • TSDocs
  • TypeScript
  • Unit tests
  • End to end tests
  • TypeScript tests
  • Update community discussions
  • Add a changeset (with link to its Feature Discussion if it exists)

Unrelated Tasks

  • Update starter themes
  • Update other packages

@changeset-bot
Copy link

changeset-bot bot commented Jun 18, 2021

⚠️ No Changeset found

Latest commit: 409fe41

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jun 18, 2021

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@DAreRodz
Copy link
Member Author

After doing some minimal testing, I've noticed that middlewares are registered for each request, again and again. That would be fixed though once we implement #695.

@SantosGuillamot should I mark the issue as blocked?

@SantosGuillamot
Copy link
Member

Sure, I have just done it 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure the middleware (server) is properly merged in the creation of the store
2 participants