Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some issues in Selenium tests #800

Draft
wants to merge 5 commits into
base: dev
Choose a base branch
from
Draft

Conversation

SantosGuillamot
Copy link
Member

What:

I've made some minor changes to ensure that the Selenium tests pass properly.

Why:

There were some errors in the Proxy and SSR tests in one of the last runs.

How:

I've added a wait in the amp tests and I've upgraded the Edge version to 18.0 because the previous versions were making some specs inconsistent.

Tasks:

  • Code

Unrelated Tasks

  • TSDocs
  • TypeScript
  • Unit tests
  • End to end tests
  • TypeScript tests
  • Update starter themes
  • Update other packages
  • Update community discussions
  • Add a changeset (with link to its Feature Discussion if it exists)

Additional Comments

@changeset-bot
Copy link

changeset-bot bot commented Apr 26, 2021

⚠️ No Changeset found

Latest commit: e4cd671

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Apr 26, 2021

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@codecov
Copy link

codecov bot commented Apr 26, 2021

Codecov Report

Merging #800 (e4cd671) into dev (49ff5ad) will not change coverage.
The diff coverage is n/a.

@github-actions
Copy link
Contributor

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants