Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for hash links in source and router #660

Draft
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

orballo
Copy link
Collaborator

@orballo orballo commented Jan 11, 2021

What:

This is the work I did so far regarding the implementation of support for hash links in source and router.

Why:

Because currently hash links are not supported.

How:

Explained here: https://community.frontity.org/t/add-support-for-hash-links-in-frontity-tiny-router/3189

Tasks:

  • Code
  • TSDocs
  • TypeScript
  • Unit tests
  • End to end tests
  • TypeScript tests
  • Update starter themes
  • Update other packages
  • Open an issue for this feature in the docs repo
  • Update community discussions
  • Add a changeset (with link to its Feature Discussion if it exists)

Unrelated Tasks

Additional Comments

@changeset-bot
Copy link

changeset-bot bot commented Jan 11, 2021

⚠️ No Changeset found

Latest commit: d55ed2c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@orballo
Copy link
Collaborator Author

orballo commented Nov 2, 2021

@luisherranz Is this issue still pending or was it implemented somewhere else?

@luisherranz
Copy link
Member

Still pending 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants