Improve the log level display #14146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrPetovan
requested changes
May 11, 2024
Comment on lines
68
to
71
| {{if $row->level == "EMERGENCY"}}bg-danger | ||
| {{elseif $row->level == "ALERT"}}bg-danger | ||
| {{elseif $row->level == "CRITICAL"}}bg-warning | ||
| {{elseif $row->level == "ERROR"}}bg-warning |
There was a problem hiding this comment.
We don't really distinguish between these 4 log levels in practice, so I would set them all to bg-danger. On the other hand, warnings can often be ignored.
There was a problem hiding this comment.
This "on the other hand" confuses me. Should I change it?
There was a problem hiding this comment.
What I'm saying is that it is counter-productive to "hide" error and critical messages behind the Warning color which doesn't necessarily prompts an admin to react to these messages. Please have only warnings use the bg-warning class, all the worse levels should use the bg-danger class.
annando
force-pushed
the
loglevels
branch
3 times, most recently
from
4f780ee
to
c661a78
Compare
MrPetovan
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves PR #14135 by adding more loglevels.