Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added categories & sorted entries in defaults.config.php #13792

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

hoergen
Copy link
Collaborator

@hoergen hoergen commented Jan 2, 2024

added categories to system section and sorted all entries more logical

added categories to system section and sorted all entries more logical
@hoergen
Copy link
Collaborator Author

hoergen commented Jan 2, 2024

How can I solve the license check problem?

In my view the header with the license looks the same. What can I do to resolve this error?

 - static/defaults.config.php
License headers are missing or wrong

@tobiasd
Copy link
Collaborator

tobiasd commented Jan 2, 2024

For now just ignore it (or I think replace the 2023 with the current year)

@hoergen
Copy link
Collaborator Author

hoergen commented Jan 2, 2024

Ahhh ok , so I only have to change 2023 to 2024 in the header? Didn't see that coming :) Thank you.
No problem. Then I create another pull request with the 2024 inside.

updated the license year to 2024
@hoergen hoergen changed the title Added categories & sorted entries Added categories & sorted entries in static/defaults.config.php Jan 2, 2024
@hoergen hoergen changed the title Added categories & sorted entries in static/defaults.config.php Added categories & sorted entries in defaults.config.php Jan 2, 2024
@MrPetovan MrPetovan added this to the 2024.03 milestone Jan 2, 2024
@MrPetovan
Copy link
Collaborator

The configuration keys were sorted in this file by alphabetical order for easier reference. I wish there were actual categories parallel to system but moving configuration keys between categories is cumbersome as we need to ensure backward compatibility.

@annando
Copy link
Collaborator

annando commented Jan 12, 2024

Concerning these categories, I guess we should do this in a way that we change the category from "system" to one that fits the best. Then we can group the values according to this.

@MrPetovan MrPetovan removed this from the 2024.03 milestone Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants