Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for arbitrary cargo subcommands #48

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

frengor
Copy link

@frengor frengor commented Aug 16, 2023

This PR adds the all-features subcommand to allow cargo-all-features to work with arbitrary cargo subcommands like Clippy and Miri.

Syntax:

cargo all-features <CARGO SUBCOMMAND> <CARGO FLAGS>

This also adds the --feature-flags-last flag to better support tools which requires a subcommand, like Miri. The flag makes cargo-all-features to put feature-related flags (--no-default-features and --features) after the additional cargo flags passed by the user. Thus, for example, to call Miri one could run cargo all-features --feature-flags-last miri test <OTHER MIRI FLAGS>.
The old binaries haven't been removed.

Fixes #5
Fixes #15
Fixes #26

@frengor
Copy link
Author

frengor commented Sep 16, 2023

@frewsxcv @Manishearth @robertbastian (sorry for the ping) Can this be reviewed?

@Manishearth
Copy link
Collaborator

I think this is probably a good idea in the long run but I don't have the time to review this right now, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cargo udeps integration miri support Support for other commands
2 participants