Flytt visning av helpLabel til over <input> i InputGroup #3885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Forhåndsvisning: https://jokul.fremtind.no/preview/3876-move-label-2/ Forhåndsvisningen blir tilgjengelig innen et par minutter. Den fjernes automatisk når pull requesten lukkes. |
fremtind-bot
added a commit
that referenced
this pull request
May 10, 2024
The deprecated props `helpLabel` and `errorLabel` on the `SupportLabel` component has been removed. Use `label` and `labelType` instead. BREAKING CHANGE: errorLabel and helpLabel props will now be ignored and are removed from the exported types
Removed the `supportLabelProps` prop from `InputGroup`, if you need to control the label's props you can use a `SupportLabel` element for either `helpLabel` or `errorLabel`. BREAKING CHANGE: `supportLabelProps` no longer exists
fremtind-bot
added a commit
that referenced
this pull request
May 10, 2024
Previously, providing both props would mean only showing the error ISSUES CLOSED: #3876
fremtind-bot
added a commit
that referenced
this pull request
May 10, 2024
fremtind-bot
added a commit
that referenced
this pull request
May 22, 2024
fremtind-bot
added a commit
that referenced
this pull request
May 22, 2024
|
Alt ser bra ut (annet enn at jeg fant en eksisterende bug, men tar ikke den her)! Men jeg lurer på om vi bør oppdatere eksempler og dokumentasjon litt. Nå er det mye dobbelt info i feilmeldinger i eksemplene, ettersom hjelpeteksten ikke lenger skjules, og vi kan fjerne/endre avsnittet som handler om nettopp repetisjon av innhold :) I tillegg må vi sørge for å få koordinert release av dette med design på en god måte! (tagger @fremtindjonas ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Sjekkliste
pnpm buildogpnpm ci:testgir ingen feil