Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[move pics to cloudflare] adding photos on cornelius documentation #6211

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

PtitLutinn
Copy link

I had put pictures with my camera during a cornelius making and I add it on the doc for next people asking for help

@boring-cyborg boring-cyborg bot added the 📖 documentation Documentation label Feb 27, 2024
Copy link

boring-cyborg bot commented Feb 27, 2024

Thanks for opening this pull request 😀 Please take a moment to read our contributing guidelines.

Copy link

vercel bot commented Feb 27, 2024

@PtitLutinn is attempting to deploy a commit to the freesewing Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Feb 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
freesewing-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2024 8:11pm

@joostdecock joostdecock changed the title adding photos on cornelius documentation [move pics to cloudflare] adding photos on cornelius documentation Mar 2, 2024
@joostdecock
Copy link
Member

Thank you for improving our documentation @PtitLutinn

However, before merging this, we need to put these images on Cloudflare (our image hoster).
It's something I can do, but I need to find some time for it.

Merging this as-is would add about 300Mb to our repo, and we need to be mindful that that would impact all contributors, so better not to.

I will keep this open until I or someone else has the time to add these to cloudflare.

@joostdecock joostdecock marked this pull request as draft March 2, 2024 14:37
@PtitLutinn
Copy link
Author

Is adding the images to cloudflare something that I can do ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 documentation Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants