Titan angled waist

[anna-puk]

Do not merge as-is! Also contains the workaround of deleting the sites/org/components/gdpr directory. (fixed)

Introducing a waist angle for titan: center back will be raised and center front lowered. This impacts e.g. charlie as well, in a way that seems to make sense.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
freesewing-lab	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 30, 2023 9:59pm
v2-freesewing-dev	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 30, 2023 9:59pm

[vercel]

@anna-puk is attempting to deploy a commit to the freesewing Team on Vercel.

A member of the Team first needs to authorize it.

[codecov]

Codecov Report

Merging #3493 (cf32c05) into develop (3fcbf56) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #3493      +/-   ##
===========================================
- Coverage    98.44%   98.42%   -0.03%     
===========================================
  Files           15       15              
  Lines         4637     4634       -3     
  Branches       583      582       -1     
===========================================
- Hits          4565     4561       -4     
- Misses          67       68       +1     
  Partials         5        5              

Flag	Coverage Δ
core	98.42% <ø> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[BenJamesBen]

I tested the changes in the localhost lab with Titan, Paco, and Charlie, and everything seems to work correctly.

[BenJamesBen]

I briefly retested the updated PR in the lab with Titan, Paco, and Charlie, and things seem to be working okay.

[joostdecock]

Can we get this out of draft? @BenJamesBen has given their seal of approval, so it seems like we should be ready to move on this. But there's some conflicts and then the comment at the very top asking not to merge this.

So where do we go from here?

[anna-puk]

Can we get this out of draft? @BenJamesBen has given their seal of approval, so it seems like we should be ready to move on this. But there's some conflicts and then the comment at the very top asking not to merge this.

So where do we go from here?

This branch also contains a commit that removes the sites/org/components/gdpr directory.

Can we get this out of draft? @BenJamesBen has given their seal of approval, so it seems like we should be ready to move on this. But there's some conflicts and then the comment at the very top asking not to merge this.

So where do we go from here?

This branch also contains a commit removing the sites/org/components/gdpr directory. I just need to revert that commit and then it should be okay to merge.

[anna-puk]

I added one extra option and restored the gdpr directory. If it still passes review, please merge! :)

[BenJamesBen]

I re-tested the updated PR, including the new useWaistAngleFor option, and I believe it is ready to be merged for wider testing.

There is no documentation for the new options. We'll want to address that in a separate PR.