Stub method shared tests #458
Commits on Feb 16, 2020
-
-
-
prep to DRY by using send instead of direct invocation
... making it identical to protected and private method cases
-
-
-
-
-
-
-
-
-
allow instantiation to be parameterized by subclassing
This will allow us to reuse StubInstanceMethodSharedTests in StubInstanceMethodDefinedOnClassTest (and perhaps others)
-
-
split StubInstanceMethodDefinedOnKernelModuleTest into two
This allows us to reuse StubInstanceMethodSharedTests for checking stubbing on a Module and stubbing on an object
-
return stubbed instance instead of stubbed class
This will allow us to reuse StubInstanceMethodSharedTests in StubInstanceMethodDefinedOnSingletonClass as instead of creating an instance from a class there, we obtain the (singleton) class from the instance.
-
-
reuse StubInstanceMethodSharedTests in StubInstanceMethodDefinedOnCla…
…ssAndAliasedTest
-
reuse StubInstanceMethodSharedTests in StubClassMethod*Test
...since class methods are just instance methods of the singleton class of class
-
allow stub_owner to be different from stubbed_instance
This will allow us to, for instance, stub a method on a superclass but check the stubbed method on its child
-
-
remove 'instance' qualifier from shared tests
... since it is now used for instance as well as class methods
-
reuse StubMethodSharedTests in StubModuleMethodTest
... and delete test_should_stub_method_within_test as covered by checks in StubMethodSharedTests
-
reuse StubMethodSharedTests in StubAnyInstanceMethodTest
delete test_should_stub_*_method_within_test as already covered by checks in StubMethodSharedTests
-
-
use shared tests for AnyInstance superclass checks
... while moving them from stub_any_instance_method_test to stub_any_instance_method_defined_on_superclass_test
-
delete test_should_be_able_to_stub_a_superclass_method
It wasn't checking stubbing of a supeclass or even a supermodule method. self.my_superclass_method from supermod isn't inherited/included in mod. So, all that it checked was that you could stub a non-existent module method.
-
extract assert_passed_with_snapshot_unchanged
... to DRY up assert_snapshot_unchanged + run_as_test + assert_passed combo
-
