Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify receivers #453

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Simplify receivers #453

wants to merge 8 commits into from

Commits on Dec 27, 2019

  1. add is_a?(Class) check to AnyInstanceReceiver 

    ... since this will always be true for classes, and reduces variance between
ObjectReceiver and AnyInstanceReceiver. This will allow us to reduce duplication
    @nitishr
    nitishr committed Dec 27, 2019
    Configuration menu
    Copy the full SHA
    f9a2dc1 View commit details
    Browse the repository at this point in the history

  2. extract mock_owner to eliminate variance in mocks 

    This will allow us to extract superclass or module since mock_owner is the only
difference between ObjectReceiver and AnyInstanceReceiver
    @nitishr
    nitishr committed Dec 27, 2019
    Configuration menu
    Copy the full SHA
    1fb156b View commit details
    Browse the repository at this point in the history

  3. extract superclass StubbedReceiver

    @nitishr
    nitishr committed Dec 27, 2019
    Configuration menu
    Copy the full SHA
    c9fba41 View commit details
    Browse the repository at this point in the history

  4. rename ObjectReceiver to InstanceReceiver 

    This makes the parallel between {Stubbed,Instance,AnyInstance}{Method,Receiver}
more apparent
    @nitishr
    nitishr committed Dec 27, 2019
    Configuration menu
    Copy the full SHA
    485438a View commit details
    Browse the repository at this point in the history

  5. merge Fake{,AnyInstance}Class into FakeClass

    @nitishr
    nitishr committed Dec 27, 2019
    Configuration menu
    Copy the full SHA
    98e7003 View commit details
    Browse the repository at this point in the history

  6. set up {Moch,Stubb}aExampleTest as acceptance tests

    @nitishr
    nitishr committed Dec 27, 2019
    Configuration menu
    Copy the full SHA
    ba9b62f View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2019

  1. rename ImpersonatingName to ImpersonatingInstanceName 

    ... to make parallels with {Instance,AnyInstance}{Method,Receiver} more apparent
    @nitishr
    nitishr committed Dec 28, 2019
    Configuration menu
    Copy the full SHA
    a70c3ab View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2020

  1. Refactor: rename mock_owner to stubbee

    @nitishr
    nitishr committed Jan 17, 2020
    Configuration menu
    Copy the full SHA
    dee3ed4 View commit details
    Browse the repository at this point in the history